From cd95d18f03fa8caae1d1c1e2ddc9c994b077e70c Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Tue, 12 May 2020 09:13:03 +1000 Subject: [PATCH] arch-kunmap_atomic-consolidate-duplicate-code-checkpatch-fixes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Al Viro WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #287: FILE: arch/nds32/mm/highmem.c:50: +EXPORT_SYMBOL(kunmap_atomic_high); WARNING: Block comments use a trailing */ on a separate line #453: FILE: include/linux/highmem.h:153: + * handles re-enabling faults + preemption */ total: 0 errors, 2 warnings, 321 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/arch-kunmap_atomic-consolidate-duplicate-code.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Al Viro Cc: Andy Lutomirski Cc: Benjamin Herrenschmidt Cc: Borislav Petkov Cc: Christian König Cc: Christoph Hellwig Cc: Chris Zankel Cc: Daniel Vetter Cc: Dan Williams Cc: Dave Hansen Cc: "David S. Miller" Cc: Helge Deller Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: Ira Weiny Cc: "James E.J. Bottomley" Cc: Max Filippov Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Thomas Bogendoerfer Cc: Thomas Gleixner Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- include/linux/highmem.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/highmem.h b/include/linux/highmem.h index fb3f724aca41c56..945b58d8a57b385 100644 --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -154,8 +154,10 @@ static inline void *kmap_atomic(struct page *page) static inline void kunmap_atomic_high(void *addr) { - /* Nothing to do in the CONFIG_HIGHMEM=n case as kunmap_atomic() - * handles re-enabling faults + preemption */ + /* + * Nothing to do in the CONFIG_HIGHMEM=n case as kunmap_atomic() + * handles re-enabling faults + preemption + */ } #define kmap_atomic_pfn(pfn) kmap_atomic(pfn_to_page(pfn))