Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactiveProperty Version 3.6.0.0 references wrong version of System.Reactive.Interfaces #49

Closed
E812 opened this issue Mar 27, 2017 · 8 comments

Comments

@E812
Copy link

E812 commented Mar 27, 2017

The actual ReactiveProperty, Version 3.6.0.0 references System.Reactive.Interfaces, Version 3.0.0.0 instead of Version 3.0.1000.0

@neuecc
Copy link
Collaborator

neuecc commented Apr 2, 2017

Install ReactiveProperty
Install reactiveui

image

This issue is not about ReactiveProperty.
reactiveui is dependent old-rx package(Rx-Main), this causes terrible issue.
But reactiveui is not fixed yet. reactiveui/ReactiveUI#1139

@E812
Copy link
Author

E812 commented Apr 2, 2017

I am not using reactiveui. I use ReactiveProperty for the ViewModel classes in my WPF application.
When I install the ReactiveProperty 3.6 package from Nuget it also installs the System.Reactive 3.1.1 packages as a dependency. I then checked my compiled assemblies with AsmSpy and it found ReactiveProperty.dll Version 3.6.0.0 references System.Reactive.Interfaces.dll Version 3.0.0.0. This is wrong as the Nuget package for System.Reactive 3.1.1 comes with a System.Reactive.Interfaces.dll in Version 3.0.1000.0.
I am not sure about the dependencies of ReactiveUI, but as they seem to stick with the older RxMain packages they should not reference the actual ReactiveProperty nuget packages.

@runceel
Copy link
Owner

runceel commented Apr 4, 2017

@E812
I'll look this issue. Sorry for my slow response.

@ventsislav-georgiev
Copy link

I have the same issue:
ReactiveProperty, Version 3.6.0.0 references System.Reactive.Interfaces, Version 3.0.0.0
ReactiveProperty.NET46, Version 3.6.0.0 references System.Reactive.Interfaces, Version 3.0.1000.0

and the latest nuget package for System.Reactive 3.1.1 is 3.0.1000.0

@runceel
Copy link
Owner

runceel commented Jun 6, 2017

hmm...

I think that this is Reactive Extension's issue.

I tried this step.

  • I created .NET Standard library project.
  • Add System.Reactive 3.1.1 package.
  • Build project.
  • Check asmspy output.

default

System.Reactive.Interfaces version 3.0.0.0 appered. What can I do for this issue?

@ventsislav-georgiev
Copy link

I see, it seems this is a big issue with pre v4 of System.Reactive - dotnet/reactive#205

Can we get a ReactiveProperty version based upon the v4 preview version System.Reactive where this issue is fixed?

@runceel
Copy link
Owner

runceel commented Jun 16, 2017

Hi.

I released ReactiveProperty v4.0.0-pre3.
https://www.nuget.org/packages/ReactiveProperty/4.0.0-pre3

Please try it!

Release note is follows:
https://github.com/runceel/ReactiveProperty/blob/vNext/ReleaseNote.md

@runceel
Copy link
Owner

runceel commented Jun 29, 2017

I close this issue.
If you have some issue then reopen this issue or create new issue.

Thank you.

@runceel runceel closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants