Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library still supported? #28

Closed
TizianoCoroneo opened this issue Feb 26, 2024 · 6 comments · Fixed by #31
Closed

Is this library still supported? #28

TizianoCoroneo opened this issue Feb 26, 2024 · 6 comments · Fixed by #31
Assignees

Comments

@TizianoCoroneo
Copy link

The latest version of the Rudderstack SDK is 2.4.3, and the current definition in the Package.swift of from: "1.0.0" will avoid updating to major versions.
Similarly, the latest version of the AppsFlyer SDK is 6.12.3 that is explicitly excluded from the specified range: "6.12.2"..<"6.12.3".

Is this library still supported? Why is the latest version of AppsFlyer explicitly excluded? Should I copy paste the content of this library into our project? Should I roll my own?

@1abhishekpandey
Copy link
Contributor

Hey @TizianoCoroneo,
I apologize for the delay in my response. Please find the following clarifications:

  1. Our iOS SDK v2 (version 2.4.3) is currently in beta. We recommend opting for the v1 SDKs v1.25.2 for a better experience and utilise this Rudder-Appsflyer integration.
  2. For the iOS SDK v2, we have a distinct RudderAppsFlyer integration. Refer to that repo: https://github.com/rudderlabs/rudder-integration-appsflyer-swift.
  3. During our last integration work, we tested it with AppsFlyerFramework SDK v6.12.2. Therefore, we have set restrictions to that specific version in the Package.swift.
  4. Currently, you have the option to utilize the latest version of the AppsFlyerFramework SDK, which is version 6.13.0, through CocoaPods. Kindly inform us if that works for you.
  5. Yes, this library is still actively supported.

Can you please answer a few queries:

  1. Would you prefer to use the latest version of the AppsFlyerFramework SDK, i.e., 6.13.0, or 6.12.3 through SMP only? If you encounter any issues with the current version (v6.12.2), please inform us.

@1abhishekpandey 1abhishekpandey self-assigned this Feb 28, 2024
@TizianoCoroneo
Copy link
Author

We always strive to stay on latest versions of everything, and following that we got rid of Cocoapods in favor of SPM almost 2 years ago. Yes I would prefer to have SPM support.

I understand pinning the version to the last version that you tested, but I think that allowing at least patch version bumps, like from 6.12.2 to 6.12.3, should be allowed.

I'll refactor our project to use Rudderstack v1 for the moment, thanks for the info.

@1abhishekpandey
Copy link
Contributor

To inform you, we plan to update the current restriction in the Swift Package Manager (SPM) so that you can utilise the latest version of the AppsFlyer SDK. The ETA for this update is late next week. I'll keep you updated.

@1abhishekpandey
Copy link
Contributor

Hey @TizianoCoroneo,
We updated the SPM restriction to allow AppsFlyer SDK versions up to less than v7.0.0. Please use the latest version, 2.5.0."

@1abhishekpandey 1abhishekpandey linked a pull request Mar 7, 2024 that will close this issue
@1abhishekpandey
Copy link
Contributor

Hey @TizianoCoroneo,
Could you please confirm if it's appropriate to close this issue?

@TizianoCoroneo
Copy link
Author

Works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants