-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation fault using toLocaleDateString #196
Comments
I am able to repro consistently @lloeki ... happens in v8. I am guessing we need to do v8 a build with more locale support. Works in my default node install
My guess here is that we need more ICU than what we are shipping with. |
Same as what we discussed here, right? I'm going to push an updated build with full ICU but was hopeful I would have had time to update mini_racer for Node 16 before. |
Cool, let me know when there is a new update, node 16 is very exciting cause we get to try out single thread stuff. I am though incredibly uneasy carrying segfault potentials around,, some people allow for sandboxing of JS segfaults are high risk vectors. |
Yeah, same. It should have thrown RangeError: Internal error. Icu error. as mentioned in the aforementioned discussion. I pushed a commit to CI with full icu on both branches. |
And the 15.14.0.1 gems are now pushed on Rubygems. |
A mini_racer install or pristine should do the work to build against the new one once installed. Tested this repro code and the one in the other issue and they're both good. Probably worth adding a regression test in mini_racer? |
I just added a test to confirm this is good, looks correct to me now! Thanks @lloeki ! |
Thank all. Sorry I've been absent from the discussion. Been juggling some deadlines at the office :( |
Ruby 2.7.2
mini_racer 0.4.0
libv8-node 15.14.0.0
The text was updated successfully, but these errors were encountered: