This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[CLI] Skip the outdated bundler check when MD5 is not available #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Jan 2, 2018
|
@bundlerbot r+ |
|
📌 Commit 824c67e has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jan 2, 2018
[CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable.
|
💔 Test failed - status-travis |
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Jan 8, 2018
[CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable.
|
💔 Test failed - status-travis |
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Jan 13, 2018
[CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable.
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Apr 11, 2018
[CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable. (cherry picked from commit 723608f)
colby-swandale
pushed a commit
that referenced
this pull request
Apr 20, 2018
[CLI] Skip the outdated bundler check when MD5 is not available ### What was the end-user problem that led to this PR? The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception. Closes #6032. ### What was your diagnosis of the problem? My diagnosis was we needed to skip the check when MD5 is unavailable. ### Why did you choose this fix out of the possible options? I chose this fix because using `#available?` would make network requests, which is not acceptable. (cherry picked from commit 723608f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception.
Closes #6032.
What was your diagnosis of the problem?
My diagnosis was we needed to skip the check when MD5 is unavailable.
Why did you choose this fix out of the possible options?
I chose this fix because using
#available?would make network requests, which is not acceptable.