Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

TSort::Cyclic: topological sort failed when running bundle install after new gem dep #2652

Closed
PragTob opened this issue Sep 27, 2013 · 4 comments

Comments

@PragTob
Copy link

PragTob commented Sep 27, 2013

Hello everyone,

at first thank you for making bundler. It really makes developer life so much easier and is one of my favorite things about ruby :-)

To the problem:
Just now I released a new version of the furoshiki gem (with the help of bundler and rake release) which we use in shoes4. Building the gem locally worked and also using the local gem from shoes4. Also gem install furoshiki works.

However when I tried to update the gem in the shoes gemspec (be it via >=, ~> ot just the version) I get this error. A branch of shoes4 with the tried update is here.

Here is my bundle env output (there is no Gemfile.lock as I tried to delete that to see if it would make it work..).

Here is a comparison of the two furoshiki versions - it might be that we/I messed something up but I can not seem to locate it.

Any help highly appreciated, thanks =)
Tobi

PS: I'm going on road trip to LA over the weekend, so I might be hard-ish to reach, I'll have at least my phone with me though

@indirect
Copy link
Member

Welllll... like it says, you have a circular dependency. :)

Shoes depends on furoshiki. But in your gisted output, furoshiki also depends on shoes! So neither one can ever be installed, because the other one has to be installed first.

@PragTob
Copy link
Author

PragTob commented Sep 27, 2013

dohhh >_>

Thank you very much Andre, sometimes I don't know what's happening.

@PragTob
Copy link
Author

PragTob commented Sep 27, 2013

Although I'd appreciate an error message that is more clear about the circular dependency situation as I can not seet that from topological sort failed. Any pointers on where in the code base I could implement that so I could fix up a PR?

@indirect
Copy link
Member

we just implemented one, and it's already in master. :) thanks for the offer, though! if you'd like to help with something else, there's a great set of possible things to be implemented right now:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants