Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Auto merge of #6238 - bundler:seg-outdated-fips, r=olleolleolle
Browse files Browse the repository at this point in the history
[CLI] Skip the outdated bundler check when MD5 is not available

### What was the end-user problem that led to this PR?

The problem was Bundler would try to do the outdated version check on FIPS systems, leading to an exception.

Closes #6032.

### What was your diagnosis of the problem?

My diagnosis was we needed to skip the check when MD5 is unavailable.

### Why did you choose this fix out of the possible options?

I chose this fix because using `#available?` would make network requests, which is not acceptable.
  • Loading branch information
bundlerbot committed Jan 2, 2018
2 parents ab14bb1 + 824c67e commit 59cbc8c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/bundler/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,8 @@ def warn_on_outdated_bundler
command_name = current_command.name
return if PARSEABLE_COMMANDS.include?(command_name)

return unless SharedHelpers.md5_available?

latest = Fetcher::CompactIndex.
new(nil, Source::Rubygems::Remote.new(URI("https://rubygems.org")), nil).
send(:compact_index_client).
Expand Down

0 comments on commit 59cbc8c

Please sign in to comment.