From 36922e7b45f431511e31a967707034eb1e0ee19f Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Sun, 9 Mar 2025 12:06:56 +0900 Subject: [PATCH] Avoid including ApplicationHelper in a controller Because this would define all helper methods as action_methods. Instead, let's call helper methods in view files as usual. --- app/controllers/proposals_controller.rb | 3 +-- app/views/proposals/parse_edit_field.js.erb | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/controllers/proposals_controller.rb b/app/controllers/proposals_controller.rb index d4c18c186..97703cf66 100644 --- a/app/controllers/proposals_controller.rb +++ b/app/controllers/proposals_controller.rb @@ -109,13 +109,12 @@ def update end end - include ApplicationHelper def parse_edit_field respond_to do |format| format.js do render locals: { field_name: params[:name], - text: markdown(params[:text]) + text: params[:text] } end end diff --git a/app/views/proposals/parse_edit_field.js.erb b/app/views/proposals/parse_edit_field.js.erb index de4919f7e..1d6c0f191 100644 --- a/app/views/proposals/parse_edit_field.js.erb +++ b/app/views/proposals/parse_edit_field.js.erb @@ -1 +1 @@ -$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j text %>'; +$('[data-field-name="<%= field_name %>"]')[0].innerHTML = '<%=j markdown(text) %>';