From 07b93549b5fca973236f0418d04fcac1367b88b2 Mon Sep 17 00:00:00 2001
From: Dmitry Vorotilin <d.vorotilin@gmail.com>
Date: Thu, 14 Sep 2023 13:16:21 +0300
Subject: [PATCH] Support for headless=new (#379)

* feat: Support for headless=new

* chore: comments

* fix: linux position spec

* fix: README.md
---
 README.md                            |   3 +-
 lib/ferrum/browser.rb                |   4 +
 lib/ferrum/browser/client.rb         |   3 +-
 lib/ferrum/browser/command.rb        |   4 +
 lib/ferrum/browser/options/chrome.rb |  11 +-
 lib/ferrum/page.rb                   |   3 +-
 spec/browser_spec.rb                 |  23 +++-
 spec/frame_spec.rb                   | 198 +++++++++++++--------------
 spec/network_spec.rb                 |  32 ++++-
 spec/page_spec.rb                    |   6 +-
 spec/support/global_helpers.rb       |   5 +-
 11 files changed, 176 insertions(+), 116 deletions(-)

diff --git a/README.md b/README.md
index 83f4c2b3..0f645862 100644
--- a/README.md
+++ b/README.md
@@ -145,7 +145,8 @@ Ferrum::Browser.new(options)
 ```
 
 * options `Hash`
-  * `:headless` (Boolean) - Set browser as headless or not, `true` by default.
+  * `:headless` (String | Boolean) - Set browser as headless or not, `true` by default. You can set `"new"` to support
+      [new headless mode](https://developer.chrome.com/articles/new-headless/).
   * `:xvfb` (Boolean) - Run browser in a virtual framebuffer, `false` by default.
   * `:window_size` (Array) - The dimensions of the browser window in which to
       test, expressed as a 2-element array, e.g. [1024, 768]. Default: [1024, 768]
diff --git a/lib/ferrum/browser.rb b/lib/ferrum/browser.rb
index cbad3b3e..8a4f3621 100644
--- a/lib/ferrum/browser.rb
+++ b/lib/ferrum/browser.rb
@@ -264,6 +264,10 @@ def version
       VersionInfo.new(command("Browser.getVersion"))
     end
 
+    def headless_new?
+      process&.command&.headless_new?
+    end
+
     private
 
     def start
diff --git a/lib/ferrum/browser/client.rb b/lib/ferrum/browser/client.rb
index b5284e00..e1136504 100644
--- a/lib/ferrum/browser/client.rb
+++ b/lib/ferrum/browser/client.rb
@@ -84,7 +84,8 @@ def raise_browser_error(error)
         case error["message"]
         # Node has disappeared while we were trying to get it
         when "No node with given id found",
-             "Could not find node with given id"
+             "Could not find node with given id",
+             "Inspected target navigated or closed"
           raise NodeNotFoundError, error
         # Context is lost, page is reloading
         when "Cannot find context with specified id"
diff --git a/lib/ferrum/browser/command.rb b/lib/ferrum/browser/command.rb
index a04c8d68..e86649d3 100644
--- a/lib/ferrum/browser/command.rb
+++ b/lib/ferrum/browser/command.rb
@@ -39,6 +39,10 @@ def xvfb?
         !!options.xvfb
       end
 
+      def headless_new?
+        @flags["headless"] == "new"
+      end
+
       def to_a
         [path] + @flags.map { |k, v| v.nil? ? "--#{k}" : "--#{k}=#{v}" }
       end
diff --git a/lib/ferrum/browser/options/chrome.rb b/lib/ferrum/browser/options/chrome.rb
index 1cce92df..3461b715 100644
--- a/lib/ferrum/browser/options/chrome.rb
+++ b/lib/ferrum/browser/options/chrome.rb
@@ -19,8 +19,9 @@ class Chrome < Base
           "keep-alive-for-test" => nil,
           "disable-popup-blocking" => nil,
           "disable-extensions" => nil,
+          "disable-component-extensions-with-background-pages" => nil,
           "disable-hang-monitor" => nil,
-          "disable-features" => "site-per-process,TranslateUI",
+          "disable-features" => "site-per-process,IsolateOrigins,TranslateUI",
           "disable-translate" => nil,
           "disable-background-networking" => nil,
           "enable-features" => "NetworkService,NetworkServiceInProcess",
@@ -32,6 +33,7 @@ class Chrome < Base
           "disable-ipc-flooding-protection" => nil,
           "disable-prompt-on-repost" => nil,
           "disable-renderer-backgrounding" => nil,
+          "disable-site-isolation-trials" => nil,
           "force-color-profile" => "srgb",
           "metrics-recording-only" => nil,
           "safebrowsing-disable-auto-update" => nil,
@@ -74,7 +76,12 @@ def merge_required(flags, options, user_data_dir)
         end
 
         def merge_default(flags, options)
-          defaults = except("headless", "disable-gpu") unless options.headless
+          defaults = case options.headless
+                     when false
+                       except("headless", "disable-gpu")
+                     when "new"
+                       except("headless").merge("headless" => "new")
+                     end
 
           defaults ||= DEFAULT_OPTIONS
           defaults.merge(flags)
diff --git a/lib/ferrum/page.rb b/lib/ferrum/page.rb
index e10d18e4..de82e690 100644
--- a/lib/ferrum/page.rb
+++ b/lib/ferrum/page.rb
@@ -390,7 +390,8 @@ def prepare_page
       resize(width: width, height: height)
 
       response = command("Page.getNavigationHistory")
-      return unless response.dig("entries", 0, "transitionType") != "typed"
+      transition_type = response.dig("entries", 0, "transitionType")
+      return if transition_type == "auto_toplevel"
 
       # If we create page by clicking links, submitting forms and so on it
       # opens a new window for which `frameStoppedLoading` event never
diff --git a/spec/browser_spec.rb b/spec/browser_spec.rb
index 4a2370ec..ff6c6e46 100644
--- a/spec/browser_spec.rb
+++ b/spec/browser_spec.rb
@@ -181,7 +181,15 @@
             proxy: { host: proxy.host, port: proxy.port, user: "u1", password: "p1" }
           )
 
-          browser.go_to("https://example.com")
+          if browser.headless_new?
+            expect { browser.go_to("https://example.com") }.to raise_error(
+              Ferrum::StatusError,
+              "Request to https://example.com failed (net::ERR_HTTP_RESPONSE_CODE_FAILURE)"
+            )
+          else
+            browser.go_to("https://example.com")
+          end
+
           expect(browser.network.status).to eq(407)
         ensure
           browser&.quit
@@ -234,6 +242,9 @@
         let(:save_path) { "/tmp/ferrum" }
 
         it "saves an attachment" do
+          # Also https://github.com/puppeteer/puppeteer/issues/10161
+          skip "https://bugs.chromium.org/p/chromium/issues/detail?id=1444729" if browser.headless_new?
+
           browser.go_to("/#{filename}")
 
           expect(File.exist?("#{save_path}/#{filename}")).to be true
@@ -531,7 +542,15 @@
         it "fails with wrong password" do
           page = browser.create_page(proxy: { host: proxy.host, port: proxy.port,
                                               user: options[:user], password: "$$" })
-          page.go_to("https://example.com")
+
+          if browser.headless_new?
+            expect { page.go_to("https://example.com") }.to raise_error(
+              Ferrum::StatusError,
+              "Request to https://example.com failed (net::ERR_HTTP_RESPONSE_CODE_FAILURE)"
+            )
+          else
+            page.go_to("https://example.com")
+          end
 
           expect(page.network.status).to eq(407)
         end
diff --git a/spec/frame_spec.rb b/spec/frame_spec.rb
index 247c92f3..b29bed66 100644
--- a/spec/frame_spec.rb
+++ b/spec/frame_spec.rb
@@ -3,33 +3,33 @@
 describe Ferrum::Frame do
   describe "#at_xpath" do
     it "works correctly when JSON is overwritten" do
-      browser.go_to("/ferrum/index")
-      browser.execute("JSON = {};")
-      expect { browser.at_xpath("//a[text() = 'JS redirect']") }.not_to raise_error
+      page.go_to("/ferrum/index")
+      page.execute("JSON = {};")
+      expect { page.at_xpath("//a[text() = 'JS redirect']") }.not_to raise_error
     end
   end
 
   it "supports selection by index" do
-    browser.go_to("/ferrum/frames")
-    frame = browser.at_xpath("//iframe").frame
+    page.go_to("/ferrum/frames")
+    frame = page.at_xpath("//iframe").frame
     expect(frame.url).to end_with("/ferrum/slow")
   end
 
   it "supports selection by element" do
-    browser.go_to("/ferrum/frames")
-    frame = browser.at_css("iframe[name]").frame
+    page.go_to("/ferrum/frames")
+    frame = page.at_css("iframe[name]").frame
     expect(frame.url).to end_with("/ferrum/slow")
   end
 
   it "supports selection by element without name or id" do
-    browser.go_to("/ferrum/frames")
-    frame = browser.at_css("iframe:not([name]):not([id])").frame
+    page.go_to("/ferrum/frames")
+    frame = page.at_css("iframe:not([name]):not([id])").frame
     expect(frame.url).to end_with("/ferrum/headers")
   end
 
   it "supports selection by element with id but no name" do
-    browser.go_to("/ferrum/frames")
-    frame = browser.at_css("iframe[id]:not([name])").frame
+    page.go_to("/ferrum/frames")
+    frame = page.at_css("iframe[id]:not([name])").frame
     expect(frame.url).to end_with("/ferrum/get_cookie")
   end
 
@@ -44,42 +44,42 @@
   end
 
   it "waits for the frame to load" do
-    browser.go_to
-    browser.execute <<-JS
+    page.go_to
+    page.execute <<-JS
       document.body.innerHTML += "<iframe src='/ferrum/slow' name='frame'>"
     JS
 
-    frame = browser.at_xpath("//iframe[@name='frame']").frame
+    frame = page.at_xpath("//iframe[@name='frame']").frame
     expect(frame.url).to end_with("/ferrum/slow")
     expect(frame.body).to include("slow page")
 
-    expect(browser.main_frame.url).to end_with("/")
+    expect(page.main_frame.url).to end_with("/")
   end
 
   it "waits for the cross-domain frame to load" do
-    browser.go_to("/ferrum/frames")
-    expect(browser.current_url).to eq(base_url("/ferrum/frames"))
-    frame = browser.at_xpath("//iframe[@name='frame']").frame
+    page.go_to("/ferrum/frames")
+    expect(page.current_url).to eq(base_url("/ferrum/frames"))
+    frame = page.at_xpath("//iframe[@name='frame']").frame
 
     expect(frame.url).to end_with("/ferrum/slow")
     expect(frame.body).to include("slow page")
 
-    expect(browser.current_url).to end_with("/ferrum/frames")
+    expect(page.current_url).to end_with("/ferrum/frames")
   end
 
   context "with src == about:blank" do
     it "doesn't hang if no document created" do
-      browser.go_to
-      browser.execute <<-JS
+      page.go_to
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='about:blank' name='frame'>"
       JS
-      frame = browser.at_xpath("//iframe[@name='frame']").frame
+      frame = page.at_xpath("//iframe[@name='frame']").frame
       expect(frame.body).to eq("<html><head></head><body></body></html>")
     end
 
     it "doesn't hang if built by JS" do
-      browser.go_to
-      browser.execute <<-JS
+      page.go_to
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='about:blank' name='frame'>";
         var iframeDocument = document.querySelector("iframe[name='frame']").contentWindow.document;
         var content = "<html><body><p>Hello Frame</p></body></html>";
@@ -87,45 +87,45 @@
         iframeDocument.write(content);
         iframeDocument.close();
       JS
-      frame = browser.at_xpath("//iframe[@name='frame']").frame
+      frame = page.at_xpath("//iframe[@name='frame']").frame
       expect(frame.body).to include("Hello Frame")
     end
   end
 
   context "with no src attribute" do
     it "doesn't hang if the srcdoc attribute is used" do
-      browser.go_to
-      browser.execute <<-JS
+      page.go_to
+      page.execute <<-JS
         document.body.innerHTML += "<iframe srcdoc='<p>Hello Frame</p>' name='frame'>"
       JS
-      frame = browser.at_xpath("//iframe[@name='frame']").frame
+      frame = page.at_xpath("//iframe[@name='frame']").frame
       expect(frame.body).to include("Hello Frame")
     end
 
     it "doesn't hang if the frame is filled by JS" do
-      browser.go_to
-      browser.execute <<-JS
+      page.go_to
+      page.execute <<-JS
         document.body.innerHTML += "<iframe id='frame' name='frame'>"
       JS
-      browser.execute <<-JS
+      page.execute <<-JS
         var iframeDocument = document.querySelector("#frame").contentWindow.document;
         var content = "<html><body><p>Hello Frame</p></body></html>";
         iframeDocument.open("text/html", "replace");
         iframeDocument.write(content);
         iframeDocument.close();
       JS
-      frame = browser.at_xpath("//iframe[@name='frame']").frame
+      frame = page.at_xpath("//iframe[@name='frame']").frame
       expect(frame.body).to include("Hello Frame")
     end
   end
 
   it "supports clicking in a frame", skip: true do
-    browser.go_to
-    browser.execute <<-JS
+    page.go_to
+    page.execute <<-JS
       document.body.innerHTML += "<iframe src='/ferrum/click_test' name='frame'>"
     JS
     sleep 0.5
-    frame = browser.at_xpath("//iframe[@name = 'frame']").frame
+    frame = page.at_xpath("//iframe[@name = 'frame']").frame
 
     log = frame.at_css("#log")
     frame.at_css("#one").click
@@ -133,11 +133,11 @@
   end
 
   it "supports clicking in a frame with padding", skip: true do
-    browser.go_to
-    browser.execute <<-JS
+    page.go_to
+    page.execute <<-JS
       document.body.innerHTML += "<iframe src='/ferrum/click_test' name='padded_frame' style='padding:100px;'>"
     JS
-    frame = browser.at_xpath("//iframe[@name = 'padded_frame']").frame
+    frame = page.at_xpath("//iframe[@name = 'padded_frame']").frame
 
     log = frame.at_css("#log")
     frame.at_css("#one").click
@@ -145,208 +145,208 @@
   end
 
   it "supports clicking in a frame nested in a frame", skip: true do
-    browser.go_to
+    page.go_to
 
     # The padding on the frame here is to differ the sizes of the two
     # frames, ensuring that their offsets are being calculated seperately.
     # This avoids a false positive where the same frame"s offset is
     # calculated twice, but the click still works because both frames had
     # the same offset.
-    browser.execute <<-JS
+    page.execute <<-JS
       document.body.innerHTML += "<iframe src='/ferrum/nested_frame_test' name='outer_frame' style='padding:200px'>"
     JS
 
     sleep 0.5
 
-    inner_frame = browser.frame_by(name: "inner_frame")
+    inner_frame = page.frame_by(name: "inner_frame")
     log = inner_frame.at_css("#log")
     inner_frame.at_css("#one").click
     expect(log.text).to eq("one")
   end
 
   it "does not wait forever for the frame to load" do
-    browser.go_to
+    page.go_to
 
-    frame = browser.frame_by(name: "omg")
+    frame = page.frame_by(name: "omg")
 
     expect(frame).to be_nil
   end
 
   it "can get the frames url" do
-    browser.go_to("/ferrum/frames")
+    page.go_to("/ferrum/frames")
 
-    frame = browser.at_xpath("//iframe").frame
+    frame = page.at_xpath("//iframe").frame
     expect(frame.url).to end_with("/ferrum/slow")
-    expect(browser.current_url).to end_with("/ferrum/frames")
+    expect(page.current_url).to end_with("/ferrum/frames")
   end
 
   it "can set page content" do
-    browser.content = "<html><head></head><body>Voila! <a href='#'>Link</a></body></html>"
+    page.content = "<html><head></head><body>Voila! <a href='#'>Link</a></body></html>"
 
-    expect(browser.body).to include("Voila!")
-    expect(browser.at_css("a").text).to eq("Link")
+    expect(page.body).to include("Voila!")
+    expect(page.at_css("a").text).to eq("Link")
   end
 
   it "gets page doctype" do
-    browser.go_to("/ferrum/frames")
-    expect(browser.doctype).to eq("<!DOCTYPE html>")
+    page.go_to("/ferrum/frames")
+    expect(page.doctype).to eq("<!DOCTYPE html>")
 
     doctype40 = %(<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">)
-    browser.content = "#{doctype40}<html><head></head><body>Voila!</body></html>"
-    expect(browser.doctype).to eq(doctype40)
+    page.content = "#{doctype40}<html><head></head><body>Voila!</body></html>"
+    expect(page.doctype).to eq(doctype40)
 
-    browser.content = ""
-    expect(browser.doctype).to be_nil
+    page.content = ""
+    expect(page.doctype).to be_nil
   end
 
   context "#xpath" do
     it "returns given nodes" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.xpath("//p[@id='remove_me']")
+      page.go_to("/ferrum/with_js")
+      p = page.xpath("//p[@id='remove_me']")
 
       expect(p.size).to eq(1)
     end
 
     it "supports within" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.xpath("//p[@id='with_content']").first
+      page.go_to("/ferrum/with_js")
+      p = page.xpath("//p[@id='with_content']").first
 
-      links = browser.xpath("./a", within: p)
+      links = page.xpath("./a", within: p)
 
       expect(links.size).to eq(1)
       expect(links.first.attribute(:id)).to eq("open-match")
     end
 
     it "throws an error on a wrong xpath" do
-      browser.go_to("/ferrum/with_js")
+      page.go_to("/ferrum/with_js")
 
       expect do
-        browser.xpath("#remove_me")
+        page.xpath("#remove_me")
       end.to raise_error(Ferrum::JavaScriptError)
     end
 
     it "supports inside a given frame" do
-      browser.go_to("/ferrum/frames")
-      browser.execute <<-JS
+      page.go_to("/ferrum/frames")
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='/ferrum/buttons' id='buttons_frame'>"
       JS
-      browser.network.wait_for_idle
+      page.network.wait_for_idle
 
-      frame = browser.at_xpath("//iframe[@id='buttons_frame']").frame
+      frame = page.at_xpath("//iframe[@id='buttons_frame']").frame
       expect(frame.xpath("//button").size).to eq(3)
     end
   end
 
   context "#at_xpath" do
     it "returns given nodes" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.at_xpath("//p[@id='remove_me']")
+      page.go_to("/ferrum/with_js")
+      p = page.at_xpath("//p[@id='remove_me']")
 
       expect(p).not_to be_nil
     end
 
     it "supports within" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.at_xpath("//p[@id='with_content']")
+      page.go_to("/ferrum/with_js")
+      p = page.at_xpath("//p[@id='with_content']")
 
-      link = browser.at_xpath("./a", within: p)
+      link = page.at_xpath("./a", within: p)
 
       expect(link).not_to be_nil
       expect(link.attribute(:id)).to eq("open-match")
     end
 
     it "throws an error on a wrong xpath" do
-      browser.go_to("/ferrum/with_js")
+      page.go_to("/ferrum/with_js")
 
       expect do
-        browser.at_xpath("#remove_me")
+        page.at_xpath("#remove_me")
       end.to raise_error(Ferrum::JavaScriptError)
     end
 
     it "supports inside a given frame" do
-      browser.go_to("/ferrum/frames")
-      browser.execute <<-JS
+      page.go_to("/ferrum/frames")
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='/ferrum/buttons' id='buttons_frame'>"
       JS
-      browser.network.wait_for_idle
+      page.network.wait_for_idle
 
-      frame = browser.at_xpath("//iframe[@id='buttons_frame']").frame
+      frame = page.at_xpath("//iframe[@id='buttons_frame']").frame
       expect(frame.at_xpath("//button[@id='click_me_123']")).not_to be_nil
     end
   end
 
   context "#css" do
     it "returns given nodes" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.css("p#remove_me")
+      page.go_to("/ferrum/with_js")
+      p = page.css("p#remove_me")
 
       expect(p.size).to eq(1)
     end
 
     it "supports within" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.css("p#with_content").first
+      page.go_to("/ferrum/with_js")
+      p = page.css("p#with_content").first
 
-      links = browser.css("a", within: p)
+      links = page.css("a", within: p)
 
       expect(links.size).to eq(1)
       expect(links.first.attribute(:id)).to eq("open-match")
     end
 
     it "throws an error on an invalid selector" do
-      browser.go_to("/ferrum/table")
+      page.go_to("/ferrum/table")
 
       expect do
-        browser.css("table tr:last")
+        page.css("table tr:last")
       end.to raise_error(Ferrum::JavaScriptError)
     end
 
     it "supports inside a given frame" do
-      browser.go_to("/ferrum/frames")
-      browser.execute <<-JS
+      page.go_to("/ferrum/frames")
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='/ferrum/buttons' id='buttons_frame'>"
       JS
-      browser.network.wait_for_idle
+      page.network.wait_for_idle
 
-      frame = browser.at_css("iframe#buttons_frame").frame
+      frame = page.at_css("iframe#buttons_frame").frame
       expect(frame.css("button").size).to eq(3)
     end
   end
 
   context "#at_css" do
     it "returns given nodes" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.at_css("p#remove_me")
+      page.go_to("/ferrum/with_js")
+      p = page.at_css("p#remove_me")
 
       expect(p).not_to be_nil
     end
 
     it "supports within" do
-      browser.go_to("/ferrum/with_js")
-      p = browser.at_css("p#with_content")
+      page.go_to("/ferrum/with_js")
+      p = page.at_css("p#with_content")
 
-      link = browser.at_css("a", within: p)
+      link = page.at_css("a", within: p)
 
       expect(link).not_to be_nil
       expect(link.attribute(:id)).to eq("open-match")
     end
 
     it "throws an error on an invalid selector" do
-      browser.go_to("/ferrum/table")
+      page.go_to("/ferrum/table")
 
       expect do
-        browser.at_css("table tr:last")
+        page.at_css("table tr:last")
       end.to raise_error(Ferrum::JavaScriptError)
     end
 
     it "supports inside a given frame" do
-      browser.go_to("/ferrum/frames")
-      browser.execute <<-JS
+      page.go_to("/ferrum/frames")
+      page.execute <<-JS
         document.body.innerHTML += "<iframe src='/ferrum/buttons' id='buttons_frame'>"
       JS
-      browser.network.wait_for_idle
+      page.network.wait_for_idle
 
-      frame = browser.at_css("iframe#buttons_frame").frame
+      frame = page.at_css("iframe#buttons_frame").frame
       expect(frame.at_css("button#click_me_123")).not_to be_nil
     end
   end
diff --git a/spec/network_spec.rb b/spec/network_spec.rb
index 5f65a8da..ee1e0d77 100644
--- a/spec/network_spec.rb
+++ b/spec/network_spec.rb
@@ -23,12 +23,16 @@
 
     it "gets cleared on restart" do
       browser.go_to("/ferrum/with_js")
-      expect(browser.network.traffic.length).to eq(4)
+      # Due to async nature of browser and the timing of favicon.ico request unpredictability
+      # we might get from x to y requests including favicon.ico
+      expect(browser.network.traffic.length).to be_between(4, 5)
 
       browser.restart
 
       browser.go_to("/ferrum/with_js")
-      expect(browser.network.traffic.length).to eq(4)
+      # Due to async nature of browser and the timing of favicon.ico request unpredictability
+      # we might get from x to y requests including favicon.ico
+      expect(browser.network.traffic.length).to be_between(4, 5)
     end
   end
 
@@ -56,8 +60,11 @@
     expect(network.total_connections).to eq(0)
 
     page.go_to("/ferrum/with_ajax_connection_refused")
+    network.wait_for_idle
 
-    expect(network.total_connections).to eq(3)
+    # Due to async nature of browser and the timing of favicon.ico request unpredictability
+    # we might get from x to y requests including favicon.ico
+    expect(network.total_connections).to be_between(3, 4)
   end
 
   it "#finished_connections" do
@@ -66,14 +73,18 @@
     page.go_to("/ferrum/with_ajax_connection_refused")
     network.wait_for_idle
 
-    expect(network.finished_connections).to eq(3)
+    # Due to async nature of browser and the timing of favicon.ico request unpredictability
+    # we might get from x to y requests including favicon.ico
+    expect(network.finished_connections).to be_between(3, 4)
   end
 
   it "#pending_connections" do
     expect(network.pending_connections).to eq(0)
 
     page.go_to("/ferrum/with_slow_ajax_connection")
-    expect(network.pending_connections).to eq(1)
+    # Due to async nature of browser and the timing of favicon.ico request unpredictability
+    # we might get from x to y requests including favicon.ico
+    expect(network.pending_connections).to be_between(1, 2)
 
     network.wait_for_idle
     expect(network.pending_connections).to eq(0)
@@ -389,7 +400,14 @@
     end
 
     it "denies without credentials" do
-      page.go_to("/ferrum/basic_auth")
+      if browser.headless_new?
+        expect { page.go_to("/ferrum/basic_auth") }.to raise_error(
+          Ferrum::StatusError,
+          %r{Request to http://.*/ferrum/basic_auth failed \(net::ERR_INVALID_AUTH_CREDENTIALS\)}
+        )
+      else
+        page.go_to("/ferrum/basic_auth")
+      end
 
       expect(network.status).to eq(401)
       expect(page.body).not_to include("Welcome, authenticated client")
@@ -459,6 +477,6 @@
       %r{Request to http://.*/ferrum/with_js failed \(net::ERR_INTERNET_DISCONNECTED\)}
     )
 
-    expect(page.body).to eq("<html><head></head><body></body></html>")
+    expect(page.at_css("body").text).to match("No internet") if browser.headless_new?
   end
 end
diff --git a/spec/page_spec.rb b/spec/page_spec.rb
index 5a76e401..7db4e498 100644
--- a/spec/page_spec.rb
+++ b/spec/page_spec.rb
@@ -53,12 +53,14 @@
   end
 
   describe "#position=" do
-    it "allows the window to be positioned", if: !Ferrum::Utils::Platform.mac? do
+    it "allows the window to be positioned" do
+      skip if Ferrum::Utils::Platform.mac? && !browser.headless_new?
+
       expect do
         page.position = { left: 10, top: 20 }
       end.to change {
         page.position
-      }.from([0, 0]).to([10, 20])
+      }.to([10, 20])
     end
   end
 
diff --git a/spec/support/global_helpers.rb b/spec/support/global_helpers.rb
index 3ae05a90..de0f767f 100644
--- a/spec/support/global_helpers.rb
+++ b/spec/support/global_helpers.rb
@@ -20,7 +20,10 @@ def network
   end
 
   def traffic
-    network.traffic
+    network.traffic.reject do |e|
+      e.url&.match?("favicon.ico") ||
+        e.request&.to_h&.fetch("documentURL") == "chrome-error://chromewebdata/"
+    end
   end
 
   def first_exchange