Endpoint Param of Type Integer Cannot Set Values Array

[xevix]

Given an Integer type parameter like the below:

optional :number, type: Integer, desc: "An integer", values: [10,11], default: 10

Grape will fail on start with the following:

grape-0.6.1/lib/grape/validations.rb:193:in `validates': type: Integer is incompatible with values: [10, 11] (Grape::Exceptions::IncompatibleOptionValues)

This is unexpected, since String and Symbol appear to work fine, and 10 and 11 are integers. I took a quick look at the validations code where the exceptions are raised but didn't understand the code too well. Is the Integer type not supported for the values check?

[dblock]

This may be a bug, but I didn't dig. Start by writing a test within grape?

[ksoderstrom]

The problem is in this check of the class of the supplied values.

https://github.com/intridea/grape/blob/master/lib/grape/validations.rb#L242-L245

The values are actually Fixnum, while the specified type is Integer. Changing the call to instance_of? to kind_of? fixes it, but does that introduce any side effects that I don't see?

[dm1try]

@ksoderstrom I don't think any side effect will appear, coerce validator does it same way https://github.com/intridea/grape/blob/master/lib/grape/validations/coerce.rb#L36
anyway you should writing a failing spec and fix it, then run all specs and you will know if something wrong :)

[dm1try]

better solution is to use coerce validator logic and DRY if it's possible

[dblock]

Closed via 4934baa.