request is nil in middleware on missing or incorrect content_type

[ChrisCPO]

We have a Logger that extends from the Grape middleman base. This logger need to have access to the request from env["api.request"] in the after method, which when a http request is sent with no content_type defined env["api.request"].request is nil which raises an error.

We are currently mounted with the use method

The following is the middle man call trace. Our middleware is API::Logger.

# Middleware call trace

## GOOD, correct content_type
### Before
API::Logger
Grape::Middleware::Versioner::Path
Grape::Middleware::Formatter

- Calls app endpoint here, logs sql whatnot

### After
Grape::Middleware::Formatter
Grape::Middleware::Versioner::Path
API::Logger

## BAD, missing content_type
### Before
API::Logger
Grape::Middleware::Versioner::Path
Grape::Middleware::Formatter

- Does NOT hit api

### After
Grape::Middleware::Versioner::Path
API::Logger
- raises error because request is missing from env["api.endpoint"]

One weird part in the bad calls is it goes up.

API::Logger
Grape::Middleware::Versioner::Path
Grape::Middleware::Formatter

but then one way down.

Grape::Middleware::Versioner::Path
API::Logger

My question is the request deleted if it does not match the content_type required or is this a bug?

[ChrisCPO]

possibly related to #1587

[dblock]

I would say seems like a bug, and I would fix #1587 first because that one is a bit clearer

That said, try writing a spec for this? It will narrow down what's going on.

[ChrisCPO]

@dblock I have a failing spec for this. I will extract it out into new rails app.

[dblock]

PR the spec instead here