Skip to content
This repository has been archived by the owner on May 6, 2019. It is now read-only.

Check deps. which use old version of Tapable #48

Closed
c0b41 opened this issue May 26, 2018 · 8 comments
Closed

Check deps. which use old version of Tapable #48

c0b41 opened this issue May 26, 2018 · 8 comments

Comments

@c0b41
Copy link

c0b41 commented May 26, 2018

working great webpack 4 but some deprecated warning show up
ekran alintisi

@rubenspgcavalcante
Copy link
Owner

This error must be from other plugin you make use as I don't use Tapable in this plugin. 👍

@ClementVidal
Copy link
Contributor

ClementVidal commented May 30, 2018

Using webpack 4.9.1, i confirm, that as soon as you add the ChromeExtensionReloader plugin, you get this warning.
The corollary is also valid, as soon as you remove the ChromeExtensionReloader the warning goes away.

After trying to create a PR for that, it seams that several packages can cause this warning:

issue 701 in extract-text-webpack-plugin

issue 225 in copy-webpack-plugin

issue 154 in webpack-bundle-analyzer

I've forked this repo and upgraded the versions of those package but the warning is still there.
I guess there are other suspicious packages that could responsible of that ...

Need a bit more investigation

@rubenspgcavalcante
Copy link
Owner

Humm, there must be some tool to check dependencies deeply, so we can find anything is using old verions of Tapable. If there's not I'll try to do some script to read the package.json files inside node_modules 🤔

@rubenspgcavalcante rubenspgcavalcante changed the title Webpak 4 Supports? Check deps. which use old version of Tapable May 30, 2018
@ClementVidal
Copy link
Contributor

I'm investigating on that.
I'll let you know if i found anything.

@ClementVidal
Copy link
Contributor

I was wrong, this warning does not come from dependencies, but from the plugin itself:

The warning seams to come from the file ChromeExtensionLoad.ts:
The .plugin() call trigger the Warning.
The point is that compiler inherit from Tapable object.

apply(compiler) {
    if (process.env.NODE_ENV !== "production") {
      compiler.plugin("compilation", comp =>
        comp.plugin(
          "after-optimize-chunk-assets",
          chunks =>
            (comp.assets = {
              ...comp.assets,
              ...this._injector(comp.assets, chunks)
            })
        )
      );

      compiler.plugin("after-emit", (comp, done) =>
        this._triggerer()
          .then(done)
          .catch(done)
      );
    }
  }

@rubenspgcavalcante
Copy link
Owner

closed by #50

@c0b41
Copy link
Author

c0b41 commented May 30, 2018

@ClementVidal thanks

@rubenspgcavalcante
Copy link
Owner

Fix published in the 0.8.1 thanks to @ClementVidal 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants