From bdad00821a5b2c2d96bee408d89cf360169634de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BAben=20Sousa?= Date: Wed, 1 Sep 2021 23:24:57 +0200 Subject: [PATCH 1/4] Add missing break statement --- .../rubensousa/gravitysnaphelper/GravitySnapRecyclerView.java | 1 + 1 file changed, 1 insertion(+) diff --git a/gravitysnaphelper/src/main/java/com/github/rubensousa/gravitysnaphelper/GravitySnapRecyclerView.java b/gravitysnaphelper/src/main/java/com/github/rubensousa/gravitysnaphelper/GravitySnapRecyclerView.java index 0166041..5a6710c 100644 --- a/gravitysnaphelper/src/main/java/com/github/rubensousa/gravitysnaphelper/GravitySnapRecyclerView.java +++ b/gravitysnaphelper/src/main/java/com/github/rubensousa/gravitysnaphelper/GravitySnapRecyclerView.java @@ -66,6 +66,7 @@ public GravitySnapRecyclerView(@NonNull Context context, @Nullable AttributeSet break; case 4: snapHelper = new GravitySnapHelper(Gravity.CENTER); + break; default: throw new IllegalArgumentException("Invalid gravity value. Use START " + "| END | BOTTOM | TOP | CENTER constants"); From 47a2b97822ca21f8f0268f417e513d8133538533 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BAben=20Sousa?= Date: Wed, 1 Sep 2021 23:26:11 +0200 Subject: [PATCH 2/4] Bump to 2.2.2 --- CHANGELOG.md | 4 ++++ gradle.properties | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68d1370..1140b3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## 2.2.2 + +- Fixed IllegalArgumentException being incorrectly thrown in `GravitySnapRecyclerView` when Gravity.CENTER is used. + ## 2.2.1 - Fixed `GravitySnapHelper` not dispatching snap events for edge items sometimes on `SnapListener` diff --git a/gradle.properties b/gradle.properties index 44db032..e1ffc29 100644 --- a/gradle.properties +++ b/gradle.properties @@ -13,7 +13,7 @@ # http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects # org.gradle.parallel=true LIBRARY_GROUP=com.github.rubensousa -LIBRARY_VERSION=2.2.1 +LIBRARY_VERSION=2.2.2 LIBRARY_ARTIFACT=gravitysnaphelper POM_NAME=GravitySnapHelper POM_DESCRIPTION=A SnapHelper that snaps the RecyclerView to an edge From 5f149c771029361276cc0e4651d6e5a30d58b168 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BAben=20Sousa?= Date: Wed, 1 Sep 2021 23:26:55 +0200 Subject: [PATCH 3/4] Bump to 2.2.2 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 163d10b..f5de518 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ A SnapHelper that snaps a RecyclerView to an edge. Add this to your build.gradle: ```groovy -implementation 'com.github.rubensousa:gravitysnaphelper:2.2.1' +implementation 'com.github.rubensousa:gravitysnaphelper:2.2.2' ``` ## How to use From 071f7c2e95de6d76b4a0d2b10126fab6dddb5d30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=BAben=20Sousa?= Date: Wed, 1 Sep 2021 23:29:51 +0200 Subject: [PATCH 4/4] Update android github action --- .github/workflows/dev.yml | 2 +- .github/workflows/master.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 379afc3..8362197 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -27,7 +27,7 @@ jobs: with: java-version: 1.8 - name: Install Android SDK - uses: malinskiy/action-android/install-sdk@release/0.0.5 + uses: malinskiy/action-android/install-sdk@release/0.1.2 - name: Run unit tests run: ./gradlew testDebugUnitTest --stacktrace -Pbintray_user=${{ secrets.BINTRAY_USER }} -Pbintray_apikey=${{ secrets.BINTRAY_KEY }} - name: Assemble library diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index f541c8e..38d14db 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -21,7 +21,7 @@ jobs: with: java-version: 1.8 - name: Install Android SDK - uses: malinskiy/action-android/install-sdk@release/0.0.5 + uses: malinskiy/action-android/install-sdk@release/0.1.2 - name: Run unit tests run: ./gradlew testDebugUnitTest --stacktrace -Pbintray_user=${{ secrets.BINTRAY_USER }} -Pbintray_apikey=${{ secrets.BINTRAY_KEY }} - name: Assemble library