Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagedown::html_resume: Inline HTML icons collide with default data-icon setting #168

Closed
Tazinho opened this issue Feb 25, 2020 · 2 comments

Comments

@Tazinho
Copy link

Tazinho commented Feb 25, 2020

As mentioned in #61 adding inline HTML icons as part of a section title will collide (literally overlap) with the default "data-icon".

Therefore, it's needed to explicitly specify "data-icon=NULL", which might not be directly obvious to new users. E.g.

<i class="fas fa-book"></i> Publications {data-icon=NULL}
--------------------------------------------------------------------------------

One possible idea for a smoother exploration of the pacakge would be to set "data-icon=NULL" as new default for section titles.

@RLesur RLesur closed this as completed in bebcb42 Mar 16, 2020
@RLesur
Copy link
Collaborator

RLesur commented Mar 16, 2020

@Tazinho Thanks for the report! This is fixed in bebcb42.

You can now use:

<i class="fas fa-book"></i> Publications
--------------------------------------------------------------------------------

I have preferred to implement a precedence of inline HTML icons over default icon and data-icon property because I don't think that anyone will do:

<i class="fas fa-book"></i> Publications {data-icon=graduation-cap}
--------------------------------------------------------------------------------

@egoipse
Copy link

egoipse commented Dec 25, 2022

Hi,

None of the solutions is working for adding inline HTML icons. Any clues why are not they working anymore?

Session Info:

R version 4.2.2 Patched (2022-11-10 r83330)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 22.04.1 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.10.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.10.0

locale:
 [1] LC_CTYPE=es_CL.UTF-8       LC_NUMERIC=C               LC_TIME=es_CL.UTF-8       
 [4] LC_COLLATE=es_CL.UTF-8     LC_MONETARY=es_CL.UTF-8    LC_MESSAGES=es_CL.UTF-8   
 [7] LC_PAPER=es_CL.UTF-8       LC_NAME=C                  LC_ADDRESS=C              
[10] LC_TELEPHONE=C             LC_MEASUREMENT=es_CL.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] compiler_4.2.2  fastmap_1.1.0   cli_3.5.0       htmltools_0.5.4 tools_4.2.2     rstudioapi_0.14
 [7] yaml_2.3.6      remotes_2.4.2   rmarkdown_2.19  knitr_1.41      pagedown_0.20   xfun_0.36      
[13] digest_0.6.31   rlang_1.0.6     evaluate_0.19 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants