-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varied trickle speed config option #29
Comments
seems legit 👍 |
Is that the go ahead to submit a pull request? |
+1 👍 |
Sounds great - if someone can draft up a PR, it'd be well appreciated! |
Pull request is over here: #78 Closing this issue off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Rico
Thanks for the great library. I've been playing around with it a turoblinks website. One cool thing that I would like to try out is a variable or random trickle speed.
Currently when you watch the progress bar it always updates at the interval, so if the interval is one second every second the progress bar moves a varied amount which doesn't seem 100% natural. Especially for longer requests where it moves say 3-4 times.
I think it would be nice to have the option to have a varied trickle speed, so setting to to 1000ms means that a random number will be used, maybe
Math.random() * Settings.trickleSpeed
orMath.random() * Settings.trickleSpeed * 2
I realise you might not want to bloat up the library if it can be avoided, but it should only be 4-5 line at most and an extra config option.
Let me know what you think, if all good then i'll send you a patch with the code and documentation :)
Cheers
The text was updated successfully, but these errors were encountered: