Avoid deprecated TestResponse#success? method #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, we're just working on fixing our ci (#2013), and then I'd like this rebased off a working build to check it's all green and I'll merge it. |
|
CI is now green. Do you think you can rebase a re-push? I can look at this, this afternoon. |
Closes rspec#2009 TestResponse#success? was deprecated with [this commit](rails/rails@af3500b). Instead, we can use #successful? from Rack::Response::Helpers. This method has been available for a long time. I tried this change with Rails 3.2, 4.2, and 5.2 and everything seemed to work fine.
98d9e55 to
436b9d0
Compare
|
|
|
Thanks a lot @composerinteralia |
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 20, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 20, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 20, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 20, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 21, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
koppen
added a commit
to substancelab/rails-boilerplate
that referenced
this pull request
Aug 21, 2019
See rspec/rspec-rails#2014 for details, fixes errors like Failure/Error: expect(response).to be_success expected #<ActionDispatch::TestResponse:0x0000560db29e9880 @mon_mutex=#<Thread::Mutex:0x0000560db29e9808>, @mo...ders:0x0000560db2cdf170 @Req=#<ActionController::TestRequest:0x0000560db29ea370 ...>>, @variant=[]>> to respond to `success?` # ./spec/controllers/people_controller_spec.rb:37:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:13:in `block (3 levels) in <main>' # ./spec/support/database_cleaner.rb:12:in `block (2 levels) in <main>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2009
TestResponse#success?was deprecated with this commit. Instead, we can use#successful?fromRack::Response::Helpers. This method has been available for a long time. I tried this change with Rails 3.2, 4.2, and 5.2 and everything seemed to work fine.