Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 #2013

benoittgt · 2018-07-15T10:10:29Z

Fix #2012

Puma now requires Ruby 2.2 minimum https://github.com/puma/puma/pull/1506/files

benoittgt · 2018-07-15T10:44:02Z

The issue is now on rdoc

Using rails 4.0.13
Installing rdoc 6.0.4
Gem::RuntimeRequirementNotMetError: rdoc requires Ruby version >= 2.2.2. The
current ruby version is 2.1.0.
An error occurred while installing rdoc (6.0.4), and Bundler cannot
continue.
Make sure that `gem install rdoc -v '6.0.4' --source 'https://rubygems.org/'`

Because of ruby/rdoc@51b03c3

benoittgt · 2018-07-15T11:44:13Z

It doesn't seem this is the way to fix rdoc issue. https://travis-ci.org/rspec/rspec-rails/builds/404100674

Do I miss something?

benoittgt · 2018-07-16T19:43:34Z

It seems to be better now. Even if it's not very stable (especially on rails 3).

Feel free to merge it if it's ok RSpec core team members.

JonRowe · 2018-07-17T08:51:30Z

Gemfile

+# Version 6.0.4 of rdoc requires Ruby 2.2
+if RUBY_VERSION < '2.2'
+  gem 'rdoc', '< 6.0.4'
+end


If rdoc is failing it's likely down in the app installs, not in our outer Gemfile, you can see in the example app generator gsub rules for generated Gemfiles which help to mitigate this.

JonRowe · 2018-07-17T08:53:39Z

Gemfile-rails-dependencies

    gem 'puma', :git => 'git://github.com/puma/puma', :branch => 'master'
  end
 when /stable$/
  gem_list = %w[rails railties actionmailer actionpack activerecord activesupport]
  gem_list << 'activejob'  if version > '4-1-stable'
  gem_list << 'actionview' if version > '4-0-stable'
-  if RUBY_VERSION  >= "1.9.3"
+  if RUBY_VERSION  >= "2.2"


~~So we'd normally do a gate here, install an older version of puma on platforms that support it, and install the latest on Ruby 2.2, this is necessary to support older rubies.~~

JonRowe · 2018-07-17T08:53:47Z

Gemfile-rails-dependencies

@@ -40,7 +40,7 @@ when nil, false, ""
 else
  gem "rails", version

-  if version >= '5-1-stable' && RUBY_VERSION  >= "1.9.3"
+  if version >= '5-1-stable' && RUBY_VERSION  >= "2.2"


~~As above.~~

benoittgt · 2018-07-18T09:01:14Z

This CI is a nightmare. I tried only on failing build on my machine and it's working. I hope I understand properly your comments @JonRowe. I will look at it tonight (UTC) again.

JonRowe · 2018-07-19T22:14:19Z

example_app_generator/generate_app.rb

@@ -47,6 +47,11 @@
    |  gem 'mime-types', '< 3'
    |end
    |
+    |# Version 6.0.4 of rdoc requires Ruby 2.2
+    |if RUBY_VERSION < '2.2'
+    |  gem 'rdoc', '< 6.0.4'


It's better to do a gsub, to specify the version only if rails adds it, and ensures theres only one, see line 24

JonRowe · 2018-07-19T22:15:42Z

Gemfile-rails-dependencies

    gem 'puma', :git => 'git://github.com/puma/puma', :branch => 'master'
  end
 when /stable$/
  gem_list = %w[rails railties actionmailer actionpack activerecord activesupport]
  gem_list << 'activejob'  if version > '4-1-stable'
  gem_list << 'actionview' if version > '4-0-stable'
-  if RUBY_VERSION  >= "1.9.3"
+  if RUBY_VERSION  >= "1.9.3" && RUBY_VERSION < "2.2"
+    gem "puma", "~> 3.11.4"


One of these (this line, and line 26) is wrong, but I'm not sure which, can puma ever be found in the rails repo?

Puma now require Ruby 2.2 minmum https://github.com/puma/puma/pull/1506/files

Because of ruby/rdoc@51b03c3

See : rspec@33e41f2

benoittgt · 2018-07-20T10:51:19Z

I read this 087cb16 and this aa93e58 and it helps me to understand what could I do.

For me we don't need puma before Ruby 2.2. Because it seems we need puma for system test added into Rails 5.1. The minimum requirement for Rails 5.1 is Ruby 2.2 https://github.com/rails/rails/blob/5-1-stable/rails.gemspec#L10

So maybe the initial commit is not a bad idea 33e41f2

For rdoc you did the change few week ago. 6a3e2bc

So I rebase from master and keep only my initial commit. We will see what CI say.

JonRowe · 2018-07-20T10:53:33Z

Actually even Rails 5 requires >= Ruby 2.2 so this should be safe

JonRowe · 2018-07-20T10:54:41Z

If this goes green merge it @benoittgt, sorry for the wild goose chase!

benoittgt · 2018-07-20T10:57:34Z

The error is now somewhere else

bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb
Traceback (most recent call last):
	3: from /home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
	2: from /home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
	1: from /home/travis/.rvm/gems/ruby-2.5.1/bin/bundle:23:in `<main>'
/home/travis/.rvm/gems/ruby-2.5.1/bin/bundle:23:in `load': cannot load such file -- /home/travis/.rvm/rubies/ruby-2.5.1/lib/ruby/gems/2.5.0/gems/bundler-1.16.3/exe/bundle (LoadError)
rake aborted!
Command failed with status (1): [bundle exec rails new ./tmp/example_app --...]
/home/travis/build/rspec/bundle/ruby/2.5.0/gems/rake-12.3.1/lib/rake/file_utils.rb:67:in `block in create_shell_runner'
/home/travis/build/rspec/bundle/ruby/2.5.0/gems/rake-12.3.1/lib/rake/file_utils.rb:57:in `sh'
/home/travis/build/rspec/rspec-rails/Rakefile:63:in `block (2 levels) in <top (required)>'

I'm gonna take a look

benoittgt · 2018-07-20T10:58:47Z

Ok. This seems linked rubygems/bundler#6629

See: rubygems/bundler#6629 Should be changed when fixed on next bundler release

benoittgt · 2018-07-20T12:08:59Z

I will monitor the status of this issue on bundler and will remove the specific version of bundler when it will be fixed.

On bundle 1.16.3 we start seeing fail builds: - rspec#2013 (comment) This is related to: - rspec#2013 (comment) As mentionned this has been fixed in 1.16.4: - rubygems/bundler#6629 (comment)

benoittgt changed the title ~~Change minimum Ruby version for Puma to 2.2~~ Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 Jul 15, 2018

benoittgt force-pushed the handle-puma-gemspec-ruby-2-2 branch 2 times, most recently from c809ae3 to a1d9f81 Compare July 16, 2018 18:54

benoittgt requested review from fables-tales and JonRowe July 17, 2018 07:09

JonRowe requested changes Jul 17, 2018

View reviewed changes

This was referenced Jul 17, 2018

Make puma log silence completely #2011

Closed

Avoid deprecated TestResponse#success? method #2014

Merged

JonRowe reviewed Jul 19, 2018

View reviewed changes

benoittgt added 7 commits July 20, 2018 12:08

Change minimum Ruby version for Puma to 2.2

8d2b95c

Puma now require Ruby 2.2 minmum https://github.com/puma/puma/pull/1506/files

Specify rdoc version when Ruby version is under 2.2

0d4547b

Because of ruby/rdoc@51b03c3

Use generated Gemfile to store rdoc specific requirement for Ruby 2.2

1a47885

Permit usage of puma 3.11.4 between Ruby 1.9.3 and 2.2

d920c30

Specify rdoc version when Ruby version is under 2.2 on generated_app

00a254e

Because of ruby/rdoc@51b03c3

Clear conflicts and rewrite puma clause

ae334b5

Revert to initial changes

65d85a3

See : rspec@33e41f2

benoittgt force-pushed the handle-puma-gemspec-ruby-2-2 branch from dc02578 to 65d85a3 Compare July 20, 2018 10:49

JonRowe approved these changes Jul 20, 2018

View reviewed changes

Avoid bundler load error on CI

c503989

See: rubygems/bundler#6629 Should be changed when fixed on next bundler release

benoittgt merged commit 814b377 into rspec:master Jul 20, 2018

benoittgt deleted the handle-puma-gemspec-ruby-2-2 branch July 20, 2018 12:07

benoittgt mentioned this pull request Sep 19, 2018

Jump to last bundler version how doesn't break on CircleCI #2027

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 #2013

Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 #2013

benoittgt commented Jul 15, 2018

benoittgt commented Jul 15, 2018

benoittgt commented Jul 15, 2018

benoittgt commented Jul 16, 2018

JonRowe Jul 17, 2018

JonRowe Jul 17, 2018 •

edited

Loading

JonRowe Jul 17, 2018 •

edited

Loading

benoittgt commented Jul 18, 2018

JonRowe Jul 19, 2018

JonRowe Jul 19, 2018

benoittgt commented Jul 20, 2018

JonRowe commented Jul 20, 2018 •

edited

Loading

JonRowe commented Jul 20, 2018

benoittgt commented Jul 20, 2018

benoittgt commented Jul 20, 2018

benoittgt commented Jul 20, 2018

Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 #2013

Change minimum Ruby version for Puma to 2.2 + specify rdoc version under 2.2 #2013

Conversation

benoittgt commented Jul 15, 2018

benoittgt commented Jul 15, 2018

benoittgt commented Jul 15, 2018

benoittgt commented Jul 16, 2018

JonRowe Jul 17, 2018

Choose a reason for hiding this comment

JonRowe Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

JonRowe Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

benoittgt commented Jul 18, 2018

JonRowe Jul 19, 2018

Choose a reason for hiding this comment

JonRowe Jul 19, 2018

Choose a reason for hiding this comment

benoittgt commented Jul 20, 2018

JonRowe commented Jul 20, 2018 • edited Loading

JonRowe commented Jul 20, 2018

benoittgt commented Jul 20, 2018

benoittgt commented Jul 20, 2018

benoittgt commented Jul 20, 2018

JonRowe Jul 17, 2018 •

edited

Loading

JonRowe Jul 17, 2018 •

edited

Loading

JonRowe commented Jul 20, 2018 •

edited

Loading