Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale_datasets interface too restrictive #25

Closed
tjlane opened this issue Oct 16, 2024 · 1 comment
Closed

scale_datasets interface too restrictive #25

tjlane opened this issue Oct 16, 2024 · 1 comment

Comments

@tjlane
Copy link
Collaborator

tjlane commented Oct 16, 2024

currently, we have this, which makes life challenging with regards to fixed column names

def scale_datasets(
    *,
    reference_dataset: rs.DataSet,
    dataset_to_scale: rs.DataSet,
    column_to_compare: str = "F",
    uncertainty_column: str = "SIGF",
    weight_using_uncertainties: bool = True,
) -> rs.DataSet:

@alisiafadini let's write down what we would want instead

@tjlane
Copy link
Collaborator Author

tjlane commented Oct 18, 2024

resolved by #27

@tjlane tjlane closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant