From 59bf03c0eeb7c76bbe68648317ee52d209ee3b28 Mon Sep 17 00:00:00 2001 From: huangkairan <18757128360@163.com> Date: Fri, 20 Oct 2023 11:26:39 +0800 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=90=9E=20fix(web-extension):=20`befor?= =?UTF-8?q?eunload`=20logic?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit check `newEvents` before `event.preventDefault` --- packages/web-extension/src/content/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-extension/src/content/index.ts b/packages/web-extension/src/content/index.ts index 5f99e974aa..fce329e711 100644 --- a/packages/web-extension/src/content/index.ts +++ b/packages/web-extension/src/content/index.ts @@ -155,8 +155,8 @@ async function initMainPage() { // Before unload pages, cache the new events in the local storage. window.addEventListener('beforeunload', (event) => { + if (!newEvents.length) return; event.preventDefault(); - if (newEvents.length === 0) return; void Browser.storage.local.set({ [LocalDataKey.bufferedEvents]: bufferedEvents.concat(newEvents), }); From 10549afab4f3632f5510aa11f4cd19667157119c Mon Sep 17 00:00:00 2001 From: huangkairan <56213366+huangkairan@users.noreply.github.com> Date: Fri, 20 Oct 2023 11:38:34 +0800 Subject: [PATCH 2/3] Create witty-kids-talk.md --- .changeset/witty-kids-talk.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/witty-kids-talk.md diff --git a/.changeset/witty-kids-talk.md b/.changeset/witty-kids-talk.md new file mode 100644 index 0000000000..fa857e74c1 --- /dev/null +++ b/.changeset/witty-kids-talk.md @@ -0,0 +1,5 @@ +--- +"@rrweb/web-extension": patch +--- + +🐞 fix(web-extension): beforeunload logic From cbf1f88b89e83bcb0b0806c8e27c24b86c1a668c Mon Sep 17 00:00:00 2001 From: huangkairan <18757128360@163.com> Date: Fri, 20 Oct 2023 11:48:18 +0800 Subject: [PATCH 3/3] foramt --- .changeset/witty-kids-talk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/witty-kids-talk.md b/.changeset/witty-kids-talk.md index fa857e74c1..4a9d4f000a 100644 --- a/.changeset/witty-kids-talk.md +++ b/.changeset/witty-kids-talk.md @@ -1,5 +1,5 @@ --- -"@rrweb/web-extension": patch +'@rrweb/web-extension': patch --- 🐞 fix(web-extension): beforeunload logic