From b4af6925f1124e7de5d0cd465eb8304901930b87 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 13 Oct 2023 08:56:31 +0200 Subject: [PATCH 1/3] fix: Fix checking for `patchTarget` in `initAdoptedStyleSheetObserver` Calling `Object.getOwnPropertyDescriptor(undefined, 'xx')` actually errors out, so let's guard there. --- packages/rrweb/src/record/observer.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/rrweb/src/record/observer.ts b/packages/rrweb/src/record/observer.ts index 428cce1a4e..416b7c86c6 100644 --- a/packages/rrweb/src/record/observer.ts +++ b/packages/rrweb/src/record/observer.ts @@ -900,10 +900,12 @@ export function initAdoptedStyleSheetObserver( host.nodeName === '#document' ? (host as Document).defaultView?.Document : host.ownerDocument?.defaultView?.ShadowRoot; - const originalPropertyDescriptor = Object.getOwnPropertyDescriptor( - patchTarget?.prototype, - 'adoptedStyleSheets', - ); + const originalPropertyDescriptor = patchTarget?.prototype + ? Object.getOwnPropertyDescriptor( + patchTarget?.prototype, + 'adoptedStyleSheets', + ) + : undefined; if ( hostId === null || hostId === -1 || From eac6040948408e42e1563fc6e79ad5d1c06ec2c0 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Fri, 13 Oct 2023 12:47:20 +0200 Subject: [PATCH 2/3] Create calm-oranges-sin.md --- .changeset/calm-oranges-sin.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/calm-oranges-sin.md diff --git a/.changeset/calm-oranges-sin.md b/.changeset/calm-oranges-sin.md new file mode 100644 index 0000000000..fdeb1db353 --- /dev/null +++ b/.changeset/calm-oranges-sin.md @@ -0,0 +1,5 @@ +--- +"rrweb": patch +--- + +fix: Fix checking for `patchTarget` in `initAdoptedStyleSheetObserver` From 3f6e65e540bf45c226700fe4f02f77ae22d5f80c Mon Sep 17 00:00:00 2001 From: mydea Date: Fri, 13 Oct 2023 10:48:55 +0000 Subject: [PATCH 3/3] Apply formatting changes --- .changeset/calm-oranges-sin.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/calm-oranges-sin.md b/.changeset/calm-oranges-sin.md index fdeb1db353..a1449698e4 100644 --- a/.changeset/calm-oranges-sin.md +++ b/.changeset/calm-oranges-sin.md @@ -1,5 +1,5 @@ --- -"rrweb": patch +'rrweb': patch --- fix: Fix checking for `patchTarget` in `initAdoptedStyleSheetObserver`