Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockchain fails on Fedora 30 since createrepo prints to stderr by default #249

Closed
cheese opened this issue Apr 18, 2019 · 3 comments
Closed

Comments

@cheese
Copy link

cheese commented Apr 18, 2019

Short description of the problem

On Fedora 30 with createrepo_c-0.12.2-1.fc30.x86_64, createrepo prints to stderr by default. And mockchain determines createrepo failure by its stderr output. So mockchain always fails.
It seems better to test createrepo exit code instead.

Output of rpm -q mock

mock-1.4.14-1.fc30.noarch

Steps to reproduce issue

  1. Run mockchain with -l option
@xsuchy xsuchy added the bug label Apr 18, 2019
@xsuchy
Copy link
Member

xsuchy commented Apr 18, 2019

Indeed, nice catch.

@xsuchy
Copy link
Member

xsuchy commented Apr 18, 2019

I temporary remove the sys.exit() when we createrepo_c prints something to STDERR.
Mockchain will still print the error (which may confuse user), but it will proceed further. I will talk to createrepo_c about this. I will leave this open until the final solution, but this error is no more fatal.

@xsuchy xsuchy closed this as completed in cf86fb1 Apr 18, 2019
@xsuchy xsuchy reopened this Apr 18, 2019
@xsuchy xsuchy added the blocked label Nov 15, 2019
@praiskup
Copy link
Member

Almost year from last update. I'd propose to close this. The mockchain.py code
disappeared, and now we only react on exit status. Which is exactly what this
issue was about.... there's --error-exit-val createrepo_c option. But using that
would be different topic. Feel free to reopen and provide more data what should
happen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants