Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize_function is NULL for ParameterEvent new_parameters, changed_parameters, deleted_parameters #378

Closed
malsbat opened this issue May 13, 2019 · 3 comments · Fixed by #379
Assignees
Labels
bug Something isn't working

Comments

@malsbat
Copy link
Contributor

malsbat commented May 13, 2019

This causes the rmw_dps implementation to crash. This worked in Crystal.

In the master branch, build/rcl_interfaces/rosidl_typesupport_introspection_cpp/rcl_interfaces/msg/parameter_event__type_support.cpp, resize_function__ParameterEvent__new_parameters is defined, but it is not included in the ParameterEvent_message_member_array structure.

In release-crystal-20190408 the resize_function is included.

I see that the check to define the function uses isinstance(member.type, AbstractSequence) whereas the check to include it is isinstance(member.type.value_type, AbstractSequence). I'm not sure which one is correct.

@jacobperron jacobperron added the bug Something isn't working label May 14, 2019
@jacobperron jacobperron self-assigned this May 14, 2019
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label May 14, 2019
@jacobperron
Copy link
Member

Looking at the following diff, I would say the check to include it should be isinstance(member.type, AbstractSequence):

416ebd8/rosidl_typesupport_introspection_cpp/resource/msg__type_support.cpp.em#diff-aba1f884b18aaf4e81588ad9968b55bfR175

See if #379 works.

@alsora
Copy link

alsora commented May 14, 2019

I tested the PR and it looks that it fixes the problem!

@malsbat
Copy link
Contributor Author

malsbat commented May 14, 2019

The PR looks good to me, thanks.

@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants