Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rosbag2_py message deserialization APIs #476

Open
mabelzhang opened this issue Jul 30, 2020 · 0 comments
Open

Simplify rosbag2_py message deserialization APIs #476

mabelzhang opened this issue Jul 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mabelzhang
Copy link
Contributor

mabelzhang commented Jul 30, 2020

Description

As a followup to #308, it would be nice to wrap around rosidl_runtime_py.utilities.get_message and rclpy.serialization.deserialize_message currently needed in the Python API, so that the Python function calls look nicer.

As a further step, it would be nice to have function calls similar to ROS 1 rosbag Python API http://wiki.ros.org/rosbag/Code%20API#Python_API

Related Issues

PR #308

Completion Criteria

Simplified Python API.
If appropriate, allow passing in a list of topics in Python.

Implementation Notes / Suggestions

One difference from ROS 1 is that where ROS 1 passes a list of topics into bag.read_messages, in rosbag2, the filter is at the storage level (rosbag2_storage/storage_filter.hpp), and the filter should be set via reader.set_filter() before reading the messages (see #302). This Python API is already implemented in the reader test of #308.

Testing Notes / Suggestions

Change rosbag2_py/test/test_sequential_reader and test_sequential_writer to use the new syntax instead of get_message and deserialize_message.

@mabelzhang mabelzhang added the enhancement New feature or request label Jul 30, 2020
@emersonknapp emersonknapp changed the title Wrap around Python reader API Simplify rosbag2_py message deserialization APIs Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant