Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport close functionality to writer in humble #1364

Closed
bernatgaston opened this issue May 31, 2023 · 1 comment
Closed

Backport close functionality to writer in humble #1364

bernatgaston opened this issue May 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bernatgaston
Copy link

bernatgaston commented May 31, 2023

Description

rosbagcpp writer in rolling has the close functionality which is necessary to create a service that starts or stops rosbag2. Otherwise, a sqlite error is launched the second time you call a rosbag with the same topics. However, the humble version does not have it.

Related Issues

#876

Completion Criteria

Close functionality added to writer

Implementation Notes / Suggestions

I created a PR already with the code since it is quite straightforward
#1363

Testing Notes / Suggestions

I don't know if a test should be added.

@bernatgaston bernatgaston added the enhancement New feature or request label May 31, 2023
@bernatgaston bernatgaston changed the title Add close functionality to writer in humble Backport close functionality to writer in humble May 31, 2023
@MichaelOrlov
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants