Skip to content

Commit

Permalink
Address linter and feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
  • Loading branch information
emersonknapp committed Jun 12, 2023
1 parent 80bddfd commit 786f648
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions rosbag2_transport/src/rosbag2_transport/recorder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ RecorderImpl::RecorderImpl(
{
if (record_options_.use_sim_time && record_options_.is_discovery_disabled) {
throw std::runtime_error(
"use_sim_time and is_discovery_disabled both set, but are incompatible settings. "
"The /clock topic needs to be discovered to record with sim time.");
"use_sim_time and is_discovery_disabled both set, but are incompatible settings. "
"The /clock topic needs to be discovered to record with sim time.");
}

std::string key_str = enum_key_code_to_str(Recorder::kPauseResumeToggleKey);
Expand Down Expand Up @@ -311,9 +311,10 @@ void RecorderImpl::record()

serialization_format_ = record_options_.rmw_serialization_format;
RCLCPP_INFO(node->get_logger(), "Listening for topics...");
if (record_options_.is_discovery_disabled) {
if (!record_options_.use_sim_time) {
subscribe_topics(get_requested_or_available_topics());
} else {
}
if (!record_options_.is_discovery_disabled) {
discovery_future_ =
std::async(std::launch::async, std::bind(&RecorderImpl::topics_discovery, this));
}
Expand Down

0 comments on commit 786f648

Please sign in to comment.