different fix for the rate failing #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks that looks good. I'll pull this in and squash it into #182 replacing my fix. |
tfoote
added a commit
that referenced
this pull request
Dec 16, 2015
different fix for the rate failing
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* * memory leak issues address those memory leak issues with the API rcutils_set_formatted_error which is defined in rcutils Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com> * * Address those memory leak issues with new MACRO add macro RCL_SET_ERROR_MSG_WITH_FORMAT_STRING which is equals RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING and fix the memory leak issues with it Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com> * address uncrustify grumble Signed-off-by: Ethan Gao <ethan.gao@linux.intel.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Implement rosbag splitting in Writer Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Update unit tests for sqlite3 storage Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Update unit tests for rosbag2_tests Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Add documentation Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Cleanup code Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Apply suggestions Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Add deleted test back in Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Apply suggestions Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Append file extension only when SqliteStorage::open is passed READ_WRITE Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Apply formatting suggestions and throw in storage open when file exists with READ_WRITE Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Add unit test for validating splitting in Writer Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Make reader use load_metadata and update tests Signed-off-by: Anas Abou Allaban <allabana@amazon.com> * Remove database_exists and make SqliteWrapper throw when database is bad Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Fix formatting and use relative_file_paths[0] from metadata Signed-off-by: Zachary Michaels <zmichaels11@gmail.com> * Check if relative file paths is empty Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me> * Update tests to reflect changes in reader Signed-off-by: Anas Abou Allaban <aabouallaban@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfoote