From 349e96c095dc9bd62e0e22b2dedac914a0101590 Mon Sep 17 00:00:00 2001 From: dhood Date: Wed, 16 Aug 2017 12:48:57 -0700 Subject: [PATCH 1/3] Provide defaults for ParameterValue fields Even though only one field for a particular parameter is intended to be used, to prevent serialisation of uninitialised fields we put defaults for all of them --- rcl_interfaces/msg/ParameterValue.msg | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rcl_interfaces/msg/ParameterValue.msg b/rcl_interfaces/msg/ParameterValue.msg index 70fe5c09..3265a6ca 100644 --- a/rcl_interfaces/msg/ParameterValue.msg +++ b/rcl_interfaces/msg/ParameterValue.msg @@ -6,8 +6,8 @@ uint8 type # "Variant" style storage of the parameter value. -bool bool_value -int64 integer_value -float64 double_value -string string_value -byte[] bytes_value +bool bool_value False +int64 integer_value 0 +float64 double_value 0.0 +string string_value "" +byte[] bytes_value [] From d99bbe460e5737703df428ff236a41d8aaf61e91 Mon Sep 17 00:00:00 2001 From: dhood Date: Wed, 16 Aug 2017 17:34:36 -0700 Subject: [PATCH 2/3] Remove unnecessary default for bytes_value --- rcl_interfaces/msg/ParameterValue.msg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcl_interfaces/msg/ParameterValue.msg b/rcl_interfaces/msg/ParameterValue.msg index 3265a6ca..b515462f 100644 --- a/rcl_interfaces/msg/ParameterValue.msg +++ b/rcl_interfaces/msg/ParameterValue.msg @@ -10,4 +10,4 @@ bool bool_value False int64 integer_value 0 float64 double_value 0.0 string string_value "" -byte[] bytes_value [] +byte[] bytes_value From 43081b34c5e102c2575861c02c090e46044b9c5c Mon Sep 17 00:00:00 2001 From: dhood Date: Thu, 17 Aug 2017 10:30:41 -0700 Subject: [PATCH 3/3] False->false to match design spec --- rcl_interfaces/msg/ParameterValue.msg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcl_interfaces/msg/ParameterValue.msg b/rcl_interfaces/msg/ParameterValue.msg index b515462f..7dabd13c 100644 --- a/rcl_interfaces/msg/ParameterValue.msg +++ b/rcl_interfaces/msg/ParameterValue.msg @@ -6,7 +6,7 @@ uint8 type # "Variant" style storage of the parameter value. -bool bool_value False +bool bool_value false int64 integer_value 0 float64 double_value 0.0 string string_value ""