Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for working with action goal IDs #389

Open
jacobperron opened this issue Feb 15, 2019 · 0 comments
Open

Add functions for working with action goal IDs #389

jacobperron opened this issue Feb 15, 2019 · 0 comments
Labels
backlog enhancement New feature or request

Comments

@jacobperron
Copy link
Member

Feature request

Feature description

Currently, the client libraries are responsible for generating UUIDs for action goal IDs when an action client makes a request. The goal ID is part of generated "send goal" service request.
Client libraries also make use of the goal IDs for maintaining a list goal handles.

Presumably, most applications do not care that an action goal ID is implemented as a UUID and should not be burdened with this knowledge. We can extend this idea to the client libraries.
It would be nice if client libraries could leverage an existing set of functions in rcl_action for working with goal IDs. These functions could be used to:

  • Generate and populate the goal ID for new goal requests
  • Compare of goal IDs
  • Getting a string representation (useful for hash maps or logging)

All without the client library needing to know the underlying representation of a goal ID.

Implementation considerations

Some applications may still want control over specifying their own goal ID generator, so it would be good if there is a feature to override the default function for generating goal IDs.

We should consider employing an existing, cross-platform, C library for working with UUIDs.
If we end up building our own, it is probably more generally useful and can reside in it's own package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant