Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👨‍🌾 Gci and Rci report cmake lint errors #31

Closed
jacobperron opened this issue Jul 20, 2021 · 1 comment
Closed

👨‍🌾 Gci and Rci report cmake lint errors #31

jacobperron opened this issue Jul 20, 2021 · 1 comment
Assignees
@cottsay
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

Both the Galactic and Rolling performance jobs are reporting cmake lint errors for src/idlgen/opendds/CMakeLists.txt, which I presume is a third-party package. Probably we should not be running linters on that package.

Example failures:
@jacobperron jacobperron added the bug Something isn't working label Jul 20, 2021
@jacobperron jacobperron changed the title 👨‍🌾 Gci and Rci report cmake lint errors Gci and Rci report cmake lint errors Jul 20, 2021
@jacobperron jacobperron changed the title Gci and Rci report cmake lint errors 👨‍🌾 Gci and Rci report cmake lint errors Jul 20, 2021
@Blast545 Blast545 mentioned this issue Mar 2, 2022
Closed
@clalancette
Copy link

Fixed by #38, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cottsay cottsay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adress cmake linter problems Blast545/performance_test
3 participants
@clalancette @cottsay @jacobperron