Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sigterm_timeout and sigkill_timeout to xml frontend #667

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Expose sigterm_timeout and sigkill_timeout to xml frontend #667

merged 4 commits into from
Nov 8, 2022

Conversation

adityapande-1995
Copy link
Contributor

This PR exposes sigkill_timeout and sigterm_timeout arguments to xml frontends. Added a simple test for parsing using xml.

Signed-off-by: Aditya aditya050995@gmail.com

@adityapande-1995
Expose sigterm_timeout and sigkill_timeout to xml frontend
08487e2 
Signed-off-by: Aditya <aditya050995@gmail.com>
clalancette
clalancette requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the test failures, can we also add a test for this to launch_yaml?

@adityapande-1995
Added test to yaml, fixed test failures in xml
e015c5c 
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995
Copy link
Contributor Author

Besides the test failures, can we also add a test for this to launch_yaml?

Done !

@adityapande-1995
pep257 fix
01cba83 
Signed-off-by: Aditya <aditya050995@gmail.com>
@wjwwood
Copy link
Member

wjwwood commented Oct 27, 2022

Redundant? #607

@wjwwood
Copy link
Member

wjwwood commented Oct 27, 2022

Since this has tests, maybe we should close #607?

@adityapande-1995 adityapande-1995 mentioned this pull request Oct 31, 2022
Closed
ivanpauno
ivanpauno reviewed Nov 7, 2022
View reviewed changes
@adityapande-1995
substitution parsing not required
d45ea31 
Signed-off-by: Aditya <aditya050995@gmail.com>
ivanpauno
ivanpauno approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@adityapande-1995
Copy link
Contributor Author

CI :

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@adityapande-1995 adityapande-1995 merged commit 352738c into rolling Nov 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the aditya/sigkill_timeout_xml branch November 8, 2022 18:53
@firesurfer firesurfer mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood left review comments

@clalancette clalancette clalancette requested changes

@ivanpauno ivanpauno ivanpauno approved these changes

@scpeters scpeters Awaiting requested review from scpeters

@hidmic hidmic Awaiting requested review from hidmic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityapande-1995 @wjwwood @clalancette @ivanpauno