Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release team #631

Closed
1 task done
pep248 opened this issue Oct 29, 2024 · 4 comments · Fixed by #654
Closed
1 task done

Add release team #631

pep248 opened this issue Oct 29, 2024 · 4 comments · Fixed by #654

Comments

@pep248
Copy link

pep248 commented Oct 29, 2024

@nuclearsandwich
Copy link
Collaborator

@pep248 can you please link to a merged rosdistro PR for the rosdistro source entry. Your current link is in a fork and therefore not valid evidence that the change has been merged.

@nuclearsandwich nuclearsandwich added the needs-rosdistro-source-link packages must be present in ros/rosdistro to demonstrate passing license and name review. label Nov 8, 2024
@pep248
Copy link
Author

pep248 commented Nov 11, 2024

@pep248 can you please link to a merged rosdistro PR for the rosdistro source entry. Your current link is in a fork and therefore not valid evidence that the change has been merged.

ros/rosdistro#43284

We are waiting for the pull-request to be accepted.

We will provide the link you requested as soon as we are accepted.

@pep248
Copy link
Author

pep248 commented Nov 19, 2024

It has been approved:
https://github.com/ros/rosdistro/blob/master/humble/distribution.yaml

  extrinsic_calibrator:
    doc:
      type: git
      url: https://github.com/Ikerlan-KER/extrinsic_calibrator.git
      version: humble
    source:
      type: git
      url: https://github.com/Ikerlan-KER/extrinsic_calibrator.git
      version: humble
    status: maintained

@nuclearsandwich nuclearsandwich removed the needs-rosdistro-source-link packages must be present in ros/rosdistro to demonstrate passing license and name review. label Nov 21, 2024
@nuclearsandwich
Copy link
Collaborator

This change has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants