From 27b9593ef32ea51308e2c6054b5d230c93aaefec Mon Sep 17 00:00:00 2001 From: Alireza Date: Wed, 21 Mar 2018 17:11:54 +0100 Subject: [PATCH] fix(actionlib): Remove `getState` error output - calling the `getState` function while no goal is running shouldn't report any error. --- include/actionlib/client/simple_action_client.h | 2 -- src/actionlib/simple_action_client.py | 1 - 2 files changed, 3 deletions(-) diff --git a/include/actionlib/client/simple_action_client.h b/include/actionlib/client/simple_action_client.h index dfe2f70a..68476cb1 100644 --- a/include/actionlib/client/simple_action_client.h +++ b/include/actionlib/client/simple_action_client.h @@ -338,8 +338,6 @@ template SimpleClientGoalState SimpleActionClient::getState() const { if (gh_.isExpired()) { - ROS_ERROR_NAMED("actionlib", - "Trying to getState() when no goal is running. You are incorrectly using SimpleActionClient"); return SimpleClientGoalState(SimpleClientGoalState::LOST); } diff --git a/src/actionlib/simple_action_client.py b/src/actionlib/simple_action_client.py index f04c43db..c2e24616 100644 --- a/src/actionlib/simple_action_client.py +++ b/src/actionlib/simple_action_client.py @@ -161,7 +161,6 @@ def get_result(self): ## SimpleActionClient isn't tracking a goal. def get_state(self): if not self.gh: - rospy.logerr("Called get_state when no goal is running") return GoalStatus.LOST status = self.gh.get_goal_status()