Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test submission for geodist (#3) #16

Closed
27 tasks
mpadge opened this issue Aug 31, 2021 · 16 comments
Closed
27 tasks

test submission for geodist (#3) #16

mpadge opened this issue Aug 31, 2021 · 16 comments

Comments

@mpadge
Copy link
Member

mpadge commented Aug 31, 2021

Submitting Author: Name (@mpadge)
Repository: https://github.com/hypertidy/geodist
Version submitted: 0.0.7
Submission type: Standard
Editor: TBD
Reviewers: TBD

Archive: TBD
Version accepted: TBD


  • Paste the full DESCRIPTION file inside a code block below:

Scope

  • Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):

    • data retrieval
    • data extraction
    • data munging
    • data deposition
    • workflow automation
    • version control
    • citation management and bibliometrics
    • scientific software wrappers
    • field and lab reproducibility tools
    • database software bindings
    • geospatial data
    • text analysis
  • Explain how and why the package falls under these categories (briefly, 1-2 sentences):

  • Who is the target audience and what are scientific applications of this package?

  • Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?

  • (If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research?

  • If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

  • Do you intend for this package to go on CRAN?

  • Do you intend for this package to go on Bioconductor?

  • Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:

MEE Options
  • The package is novel and will be of interest to the broad readership of the journal.
  • The manuscript describing the package is no longer than 3000 words.
  • You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see MEE's Policy on Publishing Code)
  • (Scope: Do consider MEE's Aims and Scope for your manuscript. We make no guarantee that your manuscript will be within MEE scope.)
  • (Although not required, we strongly recommend having a full manuscript prepared when you submit here.)
  • (Please do not submit your package separately to Methods in Ecology and Evolution)

Code of conduct

@ropensci-review-bot
Copy link
Collaborator

Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type @ropensci-review-bot help for help.

@ropensci-review-bot
Copy link
Collaborator

Error (500). The editorcheck service is currently unavailable

@mpadge
Copy link
Member Author

mpadge commented Aug 31, 2021

@ropensci-review-bot check package

@ropensci-review-bot
Copy link
Collaborator

Thanks, about to send the query.

@ropensci-review-bot
Copy link
Collaborator

🚀

Editor check started

👋

@ropensci-review-bot
Copy link
Collaborator

Checks for geodist (v0.0.7.012)

git hash: 988118a5

  • ✔️ Package uses 'roxygen2'
  • ✔️ Package has a 'contributing.md' file
  • ✖️ Package does not have a 'CITATION' file
  • ✔️ Package has a 'codemeta.json' file
  • ✔️ All functions have examples
  • ✔️ Package 'DESCRIPTION' has a URL field
  • ✔️ Package 'DESCRIPTION' has a BugReports field
  • ✔️ Package is already on CRAN
  • ✔️ Package has continuous integration checks
  • ✔️ Package coverage is 92.4%
  • ✔️ R CMD check found no errors
  • ✔️ R CMD check found no warnings

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE


1. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has:

  • code in C (87% in 14 files), C/C++ Header (3% in 3 files) and R (10% in 5 files)
  • 2 authors
  • 1 vignette
  • no internal data file
  • 1 imported package
  • 47 exported functions (median 27 lines of code)
  • no non-exported function in R (median 11 lines of code)
  • 94 C/C++ functions (median 27 lines of code)

Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The following terminology is used:

  • loc = "Lines of Code"
  • fn = "function"
  • exp/not_exp = exported / not exported

The final measure (fn_call_network_size) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile.

measure value percentile noteworthy
files_R 5 29.8
files_src 17 95.7
files_vignettes 1 64.8
files_tests 5 78.5
loc_R 319 30.2
loc_src 2783 80.3
loc_vignettes 182 67.7
loc_tests 416 68.4
num_vignettes 1 60.7
n_fns_r 47 46.4
n_fns_r_exported 47 86.1
n_fns_r_not_exported 0 0.0 TRUE
n_fns_src 94 94.8
n_fns_per_file_r 6 71.3
n_fns_per_file_src 7 57.3
num_params_per_fn 4 54.3
loc_per_fn_r 12 49.1
loc_per_fn_r_exp 27 60.6
loc_per_fn_r_not_exp 12 55.2
loc_per_fn_src 27 84.4
rel_whitespace_R 30 48.8
rel_whitespace_src 16 94.9
rel_whitespace_vignettes 12 69.6
rel_whitespace_tests 14 83.0
doclines_per_fn_exp 38 46.5
doclines_per_fn_not_exp 0 0.0 TRUE
fn_call_network_size 215 88.2

1a. Network visualisation

Interactive network visualisation of calls between objects in package can be viewed by clicking here


2. goodpractice and other checks

Details of goodpractice and other checks (click to open)

3a. Continuous Integration Badges

github

GitHub Workflow Results

name conclusion sha date
pkgdown success f45a85 2021-02-11
R-CMD-check success f45a85 2021-02-11
test-coverage success f45a85 2021-02-11

3b. goodpractice results

R CMD check with rcmdcheck

rcmdcheck found no errors, warnings, or notes

Test coverage with covr

Package coverage: 92.38

Cyclocomplexity with cyclocomp

No functions have cyclocomplexity >= 15

Static code analyses with lintr

lintr found no issues with this package!


Package Versions

package version
pkgstats 0.0.0.298
pkgcheck 0.0.1.380


Editor-in-Chief Instructions:

Processing may not proceed until the items marked with ✖️ have been resolved.

@mpadge
Copy link
Member Author

mpadge commented Aug 31, 2021

@ropensci-review-bot help

@ropensci-review-bot
Copy link
Collaborator

Hello @mpadge, here are the things you can ask me to do:


# List all available commands
@ropensci-review-bot help

# Show our Code of Conduct
@ropensci-review-bot code of conduct

# Switch to "seeking reviewers"
@ropensci-review-bot seeking reviewers

# Approve the package
@ropensci-review-bot approve

# Add a user to this issue's reviewers list
@ropensci-review-bot add xxxxx to reviewers

# Remove a user from the reviewers list
@ropensci-review-bot remove xxxxx from reviewers

# Assign a user as the editor of this submission
@ropensci-review-bot assign @username as editor

# Remove the editor assigned to this submission
@ropensci-review-bot remove editor

# Close the issue
@ropensci-review-bot approve

# Close the issue
@ropensci-review-bot out of scope

# Various package checks
@ropensci-review-bot check package

@mpadge
Copy link
Member Author

mpadge commented Aug 31, 2021

@ropensci-review-bot check package

@ropensci-review-bot
Copy link
Collaborator

Thanks, about to send the query.

@ropensci-review-bot
Copy link
Collaborator

🚀

Editor check started

👋

@ropensci-review-bot
Copy link
Collaborator

Checks for geodist (v0.0.7.012)

git hash: 988118a5

  • ✔️ Package uses 'roxygen2'
  • ✔️ Package has a 'contributing.md' file
  • ✖️ Package does not have a 'CITATION' file
  • ✔️ Package has a 'codemeta.json' file
  • ✔️ All functions have examples
  • ✔️ Package 'DESCRIPTION' has a URL field
  • ✔️ Package 'DESCRIPTION' has a BugReports field
  • ✔️ Package is already on CRAN
  • ✔️ Package has continuous integration checks
  • ✔️ Package coverage is 92.4%
  • ✔️ R CMD check found no errors
  • ✔️ R CMD check found no warnings

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE


1. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has:

  • code in C (87% in 14 files), C/C++ Header (3% in 3 files) and R (10% in 5 files)
  • 2 authors
  • 1 vignette
  • no internal data file
  • 1 imported package
  • 47 exported functions (median 27 lines of code)
  • no non-exported function in R (median 11 lines of code)
  • 94 C/C++ functions (median 27 lines of code)

Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The following terminology is used:

  • loc = "Lines of Code"
  • fn = "function"
  • exp/not_exp = exported / not exported

The final measure (fn_call_network_size) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile.

measure value percentile noteworthy
files_R 5 29.8
files_src 17 95.7
files_vignettes 1 64.8
files_tests 5 78.5
loc_R 319 30.2
loc_src 2783 80.3
loc_vignettes 182 67.7
loc_tests 416 68.4
num_vignettes 1 60.7
n_fns_r 47 46.4
n_fns_r_exported 47 86.1
n_fns_r_not_exported 0 0.0 TRUE
n_fns_src 94 94.8
n_fns_per_file_r 6 71.3
n_fns_per_file_src 7 57.3
num_params_per_fn 4 54.3
loc_per_fn_r 12 49.1
loc_per_fn_r_exp 27 60.6
loc_per_fn_r_not_exp 12 55.2
loc_per_fn_src 27 84.4
rel_whitespace_R 30 48.8
rel_whitespace_src 16 94.9
rel_whitespace_vignettes 12 69.6
rel_whitespace_tests 14 83.0
doclines_per_fn_exp 38 46.5
doclines_per_fn_not_exp 0 0.0 TRUE
fn_call_network_size 215 88.2

1a. Network visualisation

Interactive network visualisation of calls between objects in package can be viewed by clicking here


2. goodpractice and other checks

Details of goodpractice and other checks (click to open)

3a. Continuous Integration Badges

github

GitHub Workflow Results

name conclusion sha date
pkgdown success f45a85 2021-02-11
R-CMD-check success f45a85 2021-02-11
test-coverage success f45a85 2021-02-11

3b. goodpractice results

R CMD check with rcmdcheck

rcmdcheck found no errors, warnings, or notes

Test coverage with covr

Package coverage: 92.38

Cyclocomplexity with cyclocomp

No functions have cyclocomplexity >= 15

Static code analyses with lintr

lintr found no issues with this package!


Package Versions

package version
pkgstats 0.0.0.298
pkgcheck 0.0.1.380


Editor-in-Chief Instructions:

Processing may not proceed until the items marked with ✖️ have been resolved.

@mpadge
Copy link
Member Author

mpadge commented Aug 31, 2021

@ropensci-review-bot check package

@ropensci-review-bot
Copy link
Collaborator

Thanks, about to send the query.

@ropensci-review-bot
Copy link
Collaborator

🚀

Editor check started

👋

@ropensci-review-bot
Copy link
Collaborator

Checks for geodist (v0.0.7.012)

git hash: 988118a5

  • ✔️ Package uses 'roxygen2'
  • ✔️ Package has a 'contributing.md' file
  • ✖️ Package does not have a 'CITATION' file
  • ✔️ Package has a 'codemeta.json' file
  • ✔️ All functions have examples
  • ✔️ Package 'DESCRIPTION' has a URL field
  • ✔️ Package 'DESCRIPTION' has a BugReports field
  • ✔️ Package is already on CRAN
  • ✔️ Package has continuous integration checks
  • ✔️ Package coverage is 92.5%
  • ✔️ R CMD check found no errors
  • ✔️ R CMD check found no warnings

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE


1. Statistical Properties

This package features some noteworthy statistical properties which may need to be clarified by a handling editor prior to progressing.

Details of statistical properties (click to open)

The package has:

  • code in C (87% in 14 files), C/C++ Header (3% in 3 files) and R (10% in 5 files)
  • 2 authors
  • 1 vignette
  • no internal data file
  • 1 imported package
  • 3 exported functions (median 27 lines of code)
  • 42 non-exported functions in R (median 12 lines of code)
  • 94 C/C++ functions (median 27 lines of code)

Statistical properties of package structure as distributional percentiles in relation to all current CRAN packages
The following terminology is used:

  • loc = "Lines of Code"
  • fn = "function"
  • exp/not_exp = exported / not exported

The final measure (fn_call_network_size) is the total number of calls between functions (in R), or more abstract relationships between code objects in other languages. Values are flagged as "noteworthy" when they lie in the upper or lower 5th percentile.

measure value percentile noteworthy
files_R 5 29.8
files_src 17 95.7
files_vignettes 1 64.8
files_tests 5 78.5
loc_R 319 30.2
loc_src 2783 80.3
loc_vignettes 182 67.7
loc_tests 416 68.4
num_vignettes 1 60.7
n_fns_r 45 44.8
n_fns_r_exported 3 10.4
n_fns_r_not_exported 42 53.5
n_fns_src 94 94.8
n_fns_per_file_r 6 68.2
n_fns_per_file_src 7 57.3
num_params_per_fn 4 54.3
loc_per_fn_r 13 52.9
loc_per_fn_r_exp 27 60.6
loc_per_fn_r_not_exp 12 55.9
loc_per_fn_src 27 84.4
rel_whitespace_R 30 48.8
rel_whitespace_src 16 94.9
rel_whitespace_vignettes 12 69.6
rel_whitespace_tests 14 83.0
doclines_per_fn_exp 38 46.5
doclines_per_fn_not_exp 0 0.0 TRUE
fn_call_network_size 215 88.2

1a. Network visualisation

Interactive network visualisation of calls between objects in package can be viewed by clicking here


2. goodpractice and other checks

Details of goodpractice and other checks (click to open)

3a. Continuous Integration Badges

github

GitHub Workflow Results

name conclusion sha date
pkgdown success f45a85 2021-02-11
R-CMD-check success f45a85 2021-02-11
test-coverage success f45a85 2021-02-11

3b. goodpractice results

R CMD check with rcmdcheck

rcmdcheck found no errors, warnings, or notes

Test coverage with covr

Package coverage: 92.49

Cyclocomplexity with cyclocomp

No functions have cyclocomplexity >= 15

Static code analyses with lintr

lintr found no issues with this package!


Package Versions

package version
pkgstats 0.0.0.301
pkgcheck 0.0.1.380


Editor-in-Chief Instructions:

Processing may not proceed until the items marked with ✖️ have been resolved.

@mpadge mpadge closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants