use testthat's dev version and mock_output_sequence()

[maelle]

r-lib/testthat#2061 was merged so you could (but don't have to)

• you can install pak::pak("r-lib/testthat")
• register the dependency in DESCRIPTION use_dev_package("testthat") -- it'd have to be removed before submission to CRAN if you intend to do that, so it'd have to be submitted after testthat's next release
• replace your own helper with

  local_mocked_bindings(
    readline = mock_output_sequence("3", "This is a note", "n")
  )

• delete helper_mock.R

[welcome]

🎉 Thank you for opening your first issue in this repo! Please check our contribution guidelines and follow the issue template.

[RayStick]

Thanks @maelle! Sorry I seemed to have missed this.

Do you think it makes sense to do this now, or wait for testthat next release?

[maelle]

It depends on whether you're planning a CRAN release of mapmetadata yourself. If you're not, it's no big deal to use testthat dev version (at least I think so? you might discover a new bug I guess as with any version of anything 😸 ). So you could do it whenever you have time.