Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

If there's no favicon files/no logo, use rOpenSci logo? #3

Closed
maelle opened this issue May 8, 2019 · 4 comments
Closed

If there's no favicon files/no logo, use rOpenSci logo? #3

maelle opened this issue May 8, 2019 · 4 comments

Comments

@maelle
Copy link
Contributor

maelle commented May 8, 2019

That's something I was hoping to tell authors to do in the repos, via rodev::use_ro_favicon() but it might be easier to solve it centrally via your docs builder @jeroen: if there's no pkgdown folder with at least one image called favicon (see https://github.com/ropenscilabs/rodev/tree/master/pkgdown/favicon) then could you create it before building the website? E.g. https://docs.ropensci.org/cld2/ has no favicon at the moment whereas https://docs.ropensci.org/magick/ does

Likewise, if there's no logo.png in man/figures, before building the website one could be created (cf https://github.com/ropenscilabs/rodev/tree/master/man/figures) so that pkgdown would use it? If there's a logo, pkgdown uses it when creating the Twitter/OpenGraph metadata (note that this could change slightly in the future i.e. a different filename for the logo for Twitter/OpenGraph r-lib/pkgdown#936) so Twitter cards would feature the rOpenSci logo instead of nothing.

@jeroen
Copy link
Contributor

jeroen commented May 9, 2019

Note that sites hosted under https://docs.ropensci.org which do not have custom icons will default to the global favicons from the website, for example https://docs.ropensci.org/favicon.ico

@jeroen
Copy link
Contributor

jeroen commented May 27, 2019

Global favicons for docs.ropensci.org are in the github repo. These are automatically used for each site under docs.ropensci.org so I don't think there is any need for customizing these.

@jeroen jeroen closed this as completed May 27, 2019
@maelle
Copy link
Contributor Author

maelle commented May 27, 2019

yes for favicons, but no for Twitter metadata! 😉 I mean

Likewise, if there's no logo.png in man/figures, before building the website one could be created (cf https://github.com/ropenscilabs/rodev/tree/master/man/figures) so that pkgdown would use it? If there's a logo, pkgdown uses it when creating the Twitter/OpenGraph metadata (note that this could change slightly in the future i.e. a different filename for the logo for Twitter/OpenGraph r-lib/pkgdown#936) so Twitter cards would feature the rOpenSci logo instead of nothing.

@maelle maelle reopened this May 27, 2019
@maelle
Copy link
Contributor Author

maelle commented Oct 24, 2019

Dup of ropensci-org/rotemplate#21

@maelle maelle closed this as completed Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants