Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventually re-add jruby to the CI matrix #26

Open
postmodern opened this issue Nov 9, 2021 · 1 comment
Open

Eventually re-add jruby to the CI matrix #26

postmodern opened this issue Nov 9, 2021 · 1 comment
Labels
CI Continuous Integration jruby JRuby

Comments

@postmodern
Copy link
Member

postmodern commented Nov 9, 2021

Ronin now requires ruby >= 3.0. Re-enable JRuby in the CI matrix once it achieves 3.0 support.

@postmodern postmodern added the CI Continuous Integration label Nov 9, 2021
@postmodern postmodern added the jruby JRuby label Nov 9, 2021
@postmodern postmodern changed the title Re-enable jruby in the CI Eventually re-add jruby to the CI matrix Dec 5, 2021
@postmodern
Copy link
Member Author

Blocked by some weird nokogiri parsing differences under JRuby:

  1) Ronin::Web::HTML.parse must parse an HTML String and return a Nokogiri::HTML::Document
     Failure/Error: expect(doc.at('body').inner_text).to eq("Hello")
     
       expected: "Hello"
            got: "Hello\n"
     
       (compared using ==)
     
       Diff:
         <The diff is empty, are your objects producing identical `#inspect` output?>
     # ./spec/html_spec.rb:18:in `block in <main>'

  2) Ronin::Web.html should be able to parse HTML
     Failure/Error: expect(doc.at('body').inner_text).to eq("Hello")
     
       expected: "Hello"
            got: "Hello\n      "
     
       (compared using ==)
     
       Diff:
       @@ -1,2 +1,3 @@
        Hello
       +      
       
     # ./spec/web_spec.rb:19:in `block in <main>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration jruby JRuby
Projects
None yet
Development

No branches or pull requests

1 participant