From 2c1e31c5390310ae696108aa135c055452600f43 Mon Sep 17 00:00:00 2001 From: Ivana Kellyer Date: Wed, 31 Jul 2024 14:35:35 +0200 Subject: [PATCH] meta: Slim down PR template (#3382) Moved the maintainer part to the wiki. --------- Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 41dfc484ff..f0002fe486 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,16 +2,6 @@ --- -## General Notes +Thank you for contributing to `sentry-python`! Please add tests to validate your changes, and lint your code using `tox -e linters`. -Thank you for contributing to `sentry-python`! - -Please add tests to validate your changes, and lint your code using `tox -e linters`. - -Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present. - -#### For maintainers - -Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions. - -Before running sensitive test suites, please carefully check the PR. Then, apply the `Trigger: tests using secrets` label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests. +Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.