Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

JSON Parser #2351

Closed
3 of 4 tasks
Tracked by #2565
ematipico opened this issue Apr 5, 2022 · 2 comments · Fixed by #3836
Closed
3 of 4 tasks
Tracked by #2565

JSON Parser #2351

ematipico opened this issue Apr 5, 2022 · 2 comments · Fixed by #3836
Assignees
@MichaReiser
Labels
A-Parser Area: parser I-Staff Implementation: should be in charge of a core member of the team L-JSON Language: JSON S-Planned Status: planned by the team, but not in the short term

Comments

@ematipico
Copy link
Contributor

ematipico commented Apr 5, 2022 •
edited by MichaReiser
Loading

Description

We are going to use this issue to track the various work around JSON. We don't plan, for the time being, to support super languages, like JSONC, which is the format used by TypeScript.

  • create a json.ungram file where we will slowly implement new grammars
  • create a rome_json_syntax crate, where we will have all things related to the JSON syntax, generated code too
  • expand the codegen of the grammar to include JSON too
  • evaluate how to implement the parser, lexer, etc. (it will require a separate discussion)
@ematipico ematipico added umbrella Issue to track a collection of other issues L-JSON Language: JSON labels Apr 5, 2022
@loginn
Copy link
Contributor

loginn commented Apr 14, 2022 •
edited
Loading

Hey so I wrote a Json parser in rust not too long ago so I could maybe look into some of that if you'd like ? I feel like I understand the format pretty well.
IDK about the project setup though so I'd like some help with that :)

@loginn loginn mentioned this issue Apr 15, 2022
Closed
@yassere yassere added this to Rome 2022 May 8, 2022
@MichaReiser MichaReiser changed the title ☂️ JSON support ☂️ JSON Parser May 10, 2022
@MichaReiser MichaReiser mentioned this issue May 10, 2022
Closed
8 tasks
@MichaReiser MichaReiser changed the title ☂️ JSON Parser JSON Parser May 10, 2022
@MichaReiser MichaReiser removed the umbrella Issue to track a collection of other issues label May 10, 2022
@IWANABETHATGUY IWANABETHATGUY mentioned this issue Jun 27, 2022
Closed
4 tasks
@ematipico ematipico added the A-Parser Area: parser label Jun 27, 2022
@MichaReiser MichaReiser added the I-Staff Implementation: should be in charge of a core member of the team label Aug 23, 2022
@MichaReiser MichaReiser self-assigned this Oct 29, 2022
@MichaReiser MichaReiser mentioned this issue Nov 21, 2022
Merged
@github-actions
Copy link

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella

@ematipico ematipico added S-Planned Status: planned by the team, but not in the short term and removed S-Stale labels Nov 21, 2022
This was referenced Nov 23, 2022
Merged
Merged
@MichaReiser MichaReiser moved this to Done in Rome 2022 Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaReiser MichaReiser

Labels
A-Parser Area: parser I-Staff Implementation: should be in charge of a core member of the team L-JSON Language: JSON S-Planned Status: planned by the team, but not in the short term
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rome_json_parser): JSON Parser rome/tools
3 participants
@ematipico @MichaReiser @loginn