-
Notifications
You must be signed in to change notification settings - Fork 9
Add authorization #6
Comments
LGTM |
Sorry for jumping in, but I have some code ready for review if you don't mind me taking this task. |
Sure I don't. Do you want to cover all the functionality described above? |
Yes, I have all the functionality described above covered already in #7. But the PR is not approved by @roman01la. I will try to break it down into several PRs. |
@foopang Thanks! |
@foopang One thing that might save you a bit of time: try to stick to a code style of the project as much as you can, for example component names should be camel cased starting with a capital character. Basically see how the rest of the code is written and try to write your code in same manner. We want the code base to be consistent, because this project is intended to serve as a reference for others. |
I'd like to implement auth as a next part. This covers:
I suppose this functionality will be covered by several PRs.
The text was updated successfully, but these errors were encountered: