-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong complierOptions when tsconfig in cwd is extended from another tsconfig #70
Comments
I also had this same problem but I went further and had a peek into the source code of the plugin and found that it only imports the There isn't any easy workaround for this issue because TypeScript Compiler API only takes If I were one of the core maintainers of this plugin I would consider changing the |
Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. 🍺 |
@shellscape This still a relevant problem! That extended tsconfigs are not supported should be documented or fixed. Thanks for all your hard work! |
Document that extended tsconfigs are not supported. See #135
This should be fixed by rollup/rollup-plugin-typescript#153, please let us know if it's not. |
@shellscape I don't think it's fixed. I'm getting
when using |
@NotWoods any thoughts? |
Uh I have a look at rollup/rollup-plugin-typescript#153, seems that it does not solve muti-level extends? |
I'm going to reopen the issue and try to solve the failing use cases described here. |
I can confirm that the issue is still present. @NotWoods @shellscape do you have any progress with this? Maybe there is a way to use TypeScript compiler API to actually process the config as |
Could you provide a REPL link with an example of what's failing? We are using the compiler APIs Typescript provides already. The upcoming 4.0.0 version should fix some more issues too. |
Well, as others mentioned, I have a very simple setup with two Are you using TypeScript compiler to load the config or are you loading it yourselves? I've tried to find a code that is responsible for loading |
The examples in this issue all work now, so I would really appreciate the exact configuration you're using that doesn't work. I can't point to an exact location in the Typescript repo but we use the APIs provided by Typescript for parsing the configuration. |
I would have been glad to assist with this issue further, but we have had to switch to the However, if this helps in resolving this bug: config inheritance started to work correctly when I switched plugins. |
Fixed in version 4.0.0 of the typescript plugin |
@NotWoods Still not working 🙂 |
For example:
Seems that
rollup-plugin-typescript
does not try to resolve the base tsconfig, so that thecompilerOptions
is not extended.The text was updated successfully, but these errors were encountered: