Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe tests, at the very least should test against TS type definitions. #434

Closed
seivan opened this issue Jun 3, 2020 · 1 comment
Closed

Comments

@seivan
Copy link
Contributor

seivan commented Jun 3, 2020

Expected Behavior / Situation

Expect plugins to work when configuring Rollup with Typescript

Actual Behavior / Situation

Getting compiler errors with various plugins not matching Rollups type definitions.

Modification Proposal

If plugins aren't going to be written in Typescript, could they at the very least have a test case making sure they match the interface Rollup is expecting?

This one was missing name which is also documented and Rollup doesn't define it as optional, which is even better than documentation. So testing against that is a decent way of making sure the docs are followed.

@shellscape
Copy link
Collaborator

Sure, we'd be happy to review a PR for those changes. Please feel welcome to open individual PRs per plugin that you'd like to see test changes for.

Going to close this as resolved for house-cleaning purposes, as we'd welcome contributions for test improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants