From c361e40faaf07647de464218819635ac29295f50 Mon Sep 17 00:00:00 2001
From: MSevey <15232757+MSevey@users.noreply.github.com>
Date: Thu, 5 Dec 2024 12:47:02 -0500
Subject: [PATCH 1/2] fix: initial updates to full node guide

---
 guides/full-node.md | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/guides/full-node.md b/guides/full-node.md
index 517f8e92d..677508adb 100644
--- a/guides/full-node.md
+++ b/guides/full-node.md
@@ -24,16 +24,22 @@ First, update the `config_dir` in the `rollkit.toml` file:
   config_dir = "/root/.yourrollupd_fn" // [!code ++]
 ```
 
+Let's set a terminal variable for the chain ID.
+
+```sh
+CHAIN_ID=gm
+```
+
 Initialize the chain config for the full node, lets call it `FullNode` and set the chain ID to your rollup chain ID:
 
 ```bash
-rollkit init FullNode --chain-id=your-rollup-chain-id
+rollkit init FullNode --chain-id=$CHAIN_ID
 ```
 
 Copy the genesis file from the sequencer node:
 
 ```bash
-cp /root/.yourrollupd/config/genesis.json /root/.yourrollupd_fn/config/genesis.json
+cp $HOME/.$CHAIN_ID/config/genesis.json $HOME/.${CHAIN_ID}_fn/config/genesis.json
 ```
 
 ### Set Up P2P Connection to Sequencer Node
@@ -52,16 +58,27 @@ export P2P_ID="12D3KooWJbD9TQoMSSSUyfhHMmgVY3LqCjxYFz8wQ92Qa6DAqtmh"
 
 ### Start the Full Node
 
+We are now ready to run our full node. If we are running the full node on the same machine as the sequencer, we need to make sure we update the ports to avoid conflicts. 
+
+Make sure to include these flags with your start command:
+
+```sh
+  --rpc.laddr tcp://127.0.0.1:46657 \
+  --grpc.address 127.0.0.1:9390 \
+  --p2p.laddr "0.0.0.0:46656" \
+  --api.address tcp://localhost:1318
+```
+
 Run your full node with the following command:
 
 ```bash
 rollkit start --rollkit.aggregator=false \
   --rollkit.da_address http://127.0.0.1:7980 \
+  --p2p.seeds $P2P_ID@127.0.0.1:26656 \
+  --minimum-gas-prices 0stake \
   --rpc.laddr tcp://127.0.0.1:46657 \
   --grpc.address 127.0.0.1:9390 \
-  --p2p.seeds $P2P_ID@127.0.0.1:26656 \
   --p2p.laddr "0.0.0.0:46656" \
-  --json-rpc.ws-address 127.0.0.1:8547 \
   --api.address tcp://localhost:1318
 ```
 

From 60af5b4739efb672670626e67b8a2d8125926e81 Mon Sep 17 00:00:00 2001
From: gupadhyaya <ganeshrvce@gmail.com>
Date: Thu, 23 Jan 2025 11:23:24 +0400
Subject: [PATCH 2/2] remove aggregator flag for fullnode as it is not
 required, add sequencer_rollup_id flag

---
 guides/full-node.md | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/guides/full-node.md b/guides/full-node.md
index 677508adb..8cb153ac5 100644
--- a/guides/full-node.md
+++ b/guides/full-node.md
@@ -72,18 +72,19 @@ Make sure to include these flags with your start command:
 Run your full node with the following command:
 
 ```bash
-rollkit start --rollkit.aggregator=false \
+rollkit start \
   --rollkit.da_address http://127.0.0.1:7980 \
   --p2p.seeds $P2P_ID@127.0.0.1:26656 \
   --minimum-gas-prices 0stake \
   --rpc.laddr tcp://127.0.0.1:46657 \
   --grpc.address 127.0.0.1:9390 \
   --p2p.laddr "0.0.0.0:46656" \
-  --api.address tcp://localhost:1318
+  --api.address tcp://localhost:1318 \
+  --rollkit.sequencer_rollup_id gm
 ```
 
 Key points about this command:
-- `--rollkit.aggregator=false` indicates this is not an aggregator node.
+- `rollkit.sequencer_rollup_id` is generally the `$CHAIN_ID`, which is `gm` in this case.
 - The ports and addresses are different from the sequencer node to avoid conflicts. Not everything may be necessary for your setup.
 - We use the `P2P_ID` environment variable to set the seed node.