Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config backups] Model entry is created even if upload was not successfull #2594

Open
FroggyFlox opened this issue Jun 10, 2023 · 0 comments

Comments

@FroggyFlox
Copy link
Member

This is another issue noticed during work on #2569, already present in our master branch.

When uploading a config backup, a related model entry is created even if the later processing steps (such as md5 checksum, for instance) fail. This leads to an incomplete and likely not functional config backup record being created.

As noted in a recent TODO...

# TODO: use ConfigBackup() instead to avoid creating the object directly and

... I think we should just "create a temporary" ConfigBackup object instead of creating that entry directly into the database from the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant