Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env default option for rockons #2012

Open
magicalyak opened this issue Feb 4, 2019 · 3 comments
Open

add env default option for rockons #2012

magicalyak opened this issue Feb 4, 2019 · 3 comments

Comments

@magicalyak
Copy link
Contributor

This is related to rockstor/rockon-registry#174 where I realized we don't have a default option in the json that is respected for environment options in rockons.

  1. adding default has not effect
  2. I would like to be able to add default like the volume or port options for environment items
@FroggyFlox
Copy link
Member

FroggyFlox commented Feb 4, 2019

I really like this idea and would greatly improve the user-friendliness of the Rock-on install process, almost reducing it to a "Next > Next > Next..." experience. I found myself limited by that several times... That makes me ashamed not to have thought of implementing this in the same way as for the ports choice, as you suggest.

This shouldn't be too complicated to implement but would, however, require a slight addition to the database table DContainerEnv to store the default value set in the JSON file.
In order to keep compatibility with the existing Rock-ons, this would also need to be optional (which is better in my opinion anyway).

@FroggyFlox
Copy link
Member

Adding a new feedback from the forum supporting the integration of this feature:
https://forum.rockstor.com/t/add-a-default-value-to-the-environment-object-of-rockon-conf-file/8633

That post should be updated upon resolution of this issue.

@FroggyFlox
Copy link
Member

Adding another forum thread requesting this feature:
https://forum.rockstor.com/t/optional-environment-variables-in-rock-ons/8756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants