Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rock-Ons] Add_storage affects all containers in a Rock-On #2000

Open
FroggyFlox opened this issue Dec 11, 2018 · 1 comment
Open

[Rock-Ons] Add_storage affects all containers in a Rock-On #2000

FroggyFlox opened this issue Dec 11, 2018 · 1 comment

Comments

@FroggyFlox
Copy link
Member

FroggyFlox commented Dec 11, 2018

When one adds a share to an already-installed Rock-On through the webUI "Add Storage" function, all containers in the Rock-On are affected. See below for an example in which the share test_share01 was added to the Rock-On.
Before the modification, we have:

[root@rockdev ~]# docker inspect   --format "{{.Mounts}}" helloworld1
[{bind  /etc/localtime /etc/localtime  ro false rprivate}]

After we have:

[root@rockdev ~]# docker inspect   --format "{{.Mounts}}" helloworld1
[{bind  /etc/localtime /etc/localtime  ro false rprivate} {bind  /mnt2/test_share01 /test_volume01   true rprivate}]
[root@rockdev ~]# docker inspect   --format "{{.Mounts}}" helloworld2
[{bind  /mnt2/test_share01 /test_volume01   true rprivate} {bind  /etc/localtime /etc/localtime  ro false rprivate}]

The webUI now shows:
image

This is simply due to the fact that the feature is not container-aware so the update procedure goes through all containers with the given rockon.id.
Making this feature work at the container level rather than the Rock-on level could help customizing multi-containers Rock-On. This could be done in a similar way than in a (currently pending) PR: #1999.

Note that this simply is a refinement of an existing feature.

@phillxnet
Copy link
Member

@FroggyFlox Nice find, and I agree that this would make for a valuable refinement in the style of your recent additions in this area. A tricky balance to keep between not over complicating a UI and providing adequate resolution of configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants