Samba Custom configuration UI glitch

[ralphys]

This is not a serious bug but I want to report it anyways.

The Custom configuration text box in Samba Shares has annoying blank spaces all around... I had to actually SSH into the box and look at the the smb.conf to make sure nothing was messy there.

Fortunately, this does not seem to affect usability and all parameters are set properly in the configuration.

[MFlyer]

Hi @ralphys ,
thanks for this, can you please tell us your current Rockstor version?
I had lot of code over Rockstor Samba and I remember I had some code over this too :)

If not an old version related issue, will check it asap
Mirko

[ralphys]

I'm on 3.9.0-0; stable updates... so not sure if it was pushed to testing and that's why I don't see it.

[MFlyer]

Samba related code was on 3.8.16 cycle, so 3.9.0 has it
Will check it again :)

[MFlyer]

Hi @ralphys , got it: I fixed those glitches over Samba global config (under services), but not on share custom config, will fix it!
Mirko

[MFlyer]

Thanks @ralphys , it was because of textarea element behaviours ( on textareas tabs, carriage returns and spaces always rendered) plus a minor javascript code fix

PR on its way
Mirko