You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You are running the homebrew release.
cli: v3.0.0
lib: v3.0.0
node: v20.18.0
Describe the issue
When importing a Journey that contains Scripted Decision Nodes, the import is formatting the script to be a single line. This is resulting in breaking Journeys as the script is likely fully commented out and cannot execute.
frodo journey import -a -f scriptingtutorial_v2.json <tenant>
Importing all journeys from a single file (scriptingtutorial_v2.json)...
✔ Resolved all dependencies.
[========================================] 100% | 3/3 | Finished importing journeys
Results in the Following Journeys being added to your tenant (under Workshop/Scripting):
V2_Scripting1_Outcomes
V2_Scripting2_APIs
V2_Scripting3_Debugging
If you click in on any of these Journeys and select a Scripted Decision Node, you'll find that the script is a single line. For example, V2_Scripting2_APIs -> Coin Flip with API - Next Gen is a single line Script.
If you import the same series of Journeys with the UI, the Journey successfully imports.
The text was updated successfully, but these errors were encountered:
I figured out the issue. The problem is due to a change I made in a previous PR. Before my fix, it was doing JSON.parse on the script before an import. What I just realized now is that this is needed to support imports because exports, both from AIC and from Frodo, export the journey scripts as a string within a string, so JSON.parse makes it into a normal string for the import so we don't run into this issue.
The reason I made the change originally was because we were doing the same thing in ScriptOps which was causing problems on import, so I removed it there and also in the journeys thinking it was a problem in the journeys as well. The fix should be as simple as re-adding the JSON.parse in JourneyOps, so I will go ahead and make a PR for that tomorrow.
Frodo CLI version
Describe the issue
When importing a Journey that contains Scripted Decision Nodes, the import is formatting the script to be a single line. This is resulting in breaking Journeys as the script is likely fully commented out and cannot execute.
Steps to Reproduce
Using the example Journey found here
Importing with the command
frodo journey import -a -f scriptingtutorial_v2.json <tenant>
Results in the Following Journeys being added to your tenant (under Workshop/Scripting):
If you click in on any of these Journeys and select a Scripted Decision Node, you'll find that the script is a single line. For example,
V2_Scripting2_APIs
->Coin Flip with API - Next Gen
is a single line Script.If you import the same series of Journeys with the UI, the Journey successfully imports.
The text was updated successfully, but these errors were encountered: