From 6b8d2e56e0d54049bf7b4dd7b4f46985345a8bb5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Reynir=20Bj=C3=B6rnsson?= Date: Thu, 10 Oct 2024 11:02:40 +0200 Subject: [PATCH 1/2] Use Log instead of Logs --- src/happy_eyeballs.ml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/happy_eyeballs.ml b/src/happy_eyeballs.ml index b9c1074..0577051 100644 --- a/src/happy_eyeballs.ml +++ b/src/happy_eyeballs.ml @@ -329,9 +329,9 @@ let event t now e = Connect (name, id, c.attempt, dst) :: actions | Resolving _ts -> Waiting_for_aaaa (now, ips), c.attempt, actions | Waiting_for_aaaa (ts, ips') -> - Logs.warn (fun m -> m "already waiting for AAAA with %a" - Fmt.(list ~sep:(any ", ") Ipaddr.V4.pp) - (Ipaddr.V4.Set.elements ips')); + Log.warn (fun m -> m "already waiting for AAAA with %a" + Fmt.(list ~sep:(any ", ") Ipaddr.V4.pp) + (Ipaddr.V4.Set.elements ips')); Waiting_for_aaaa (ts, Ipaddr.V4.Set.union ips' ips), c.attempt, actions | Connecting (ts, dst, dsts) -> From ac9d35c21ab610584a397db7af9a239bb131d1e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Reynir=20Bj=C3=B6rnsson?= Date: Thu, 10 Oct 2024 11:27:38 +0200 Subject: [PATCH 2/2] Apply suggestions from review - Demote to debug logging, - Print as well the host in question Co-authored-by: Hannes Mehnert --- src/happy_eyeballs.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/happy_eyeballs.ml b/src/happy_eyeballs.ml index 0577051..c984980 100644 --- a/src/happy_eyeballs.ml +++ b/src/happy_eyeballs.ml @@ -329,7 +329,8 @@ let event t now e = Connect (name, id, c.attempt, dst) :: actions | Resolving _ts -> Waiting_for_aaaa (now, ips), c.attempt, actions | Waiting_for_aaaa (ts, ips') -> - Log.warn (fun m -> m "already waiting for AAAA with %a" + Log.debug (fun m -> m "%a already waiting for AAAA with %a" + Domain_name.pp name Fmt.(list ~sep:(any ", ") Ipaddr.V4.pp) (Ipaddr.V4.Set.elements ips')); Waiting_for_aaaa (ts, Ipaddr.V4.Set.union ips' ips), c.attempt,