Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarprobotinterface with enabled_by and disabled_by xml attributes #2890

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Nov 8, 2022

yarprobotinterface: is now able to interactively enable/disable sections of the xml configuration files included through the xi:include tag. See attached yarprobotinterface Doxygen documentation.

…_by` xml attributes.

See attached yarprobotinterface Doxygen documentation.
@randaz81 randaz81 self-assigned this Nov 8, 2022
@randaz81 randaz81 temporarily deployed to code-analysis November 8, 2022 15:08 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 8, 2022 15:08 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 8, 2022 15:08 Inactive
@pattacini
Copy link
Member

cc @davidetome @sgiraz @mfussi66 @triccyx @marcoaccame

traversaro
traversaro previously approved these changes Nov 8, 2022
@@ -56,6 +56,7 @@ class yarp::robotinterface::impl::XMLReaderFileV3::Private
yarp::robotinterface::Action readActionTag(TiXmlElement* actionElem, yarp::robotinterface::XMLReaderResult& result);
yarp::robotinterface::ActionList readActionsTag(TiXmlElement* actionsElem, yarp::robotinterface::XMLReaderResult& result);

bool Check_include_section_is_enabled(const std::string& href_enable_tags, const std::string& href_disable_tags);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor/Feel free to ignore: the rest of the class use CamelCase names for the Methods

@randaz81 randaz81 temporarily deployed to code-analysis November 11, 2022 16:24 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 11, 2022 16:24 Inactive
@randaz81 randaz81 temporarily deployed to code-analysis November 11, 2022 16:24 Inactive
@randaz81 randaz81 merged commit f03dd5d into robotology:master Nov 11, 2022
@randaz81 randaz81 deleted the yarprobotinterface_enabled_tags branch November 15, 2022 12:42
@randaz81 randaz81 added this to the YARP 3.8.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants