-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CMake code to install YARP devices #79
Comments
Done with #80, did it fixed the problem with |
I have no idea. : ) |
@lrapetti drop a comment here before closing. |
Closing via #80 |
To clarify, new version of wearables are included in the Windows binary only when they are released and the corresponding version is bumped in the .yaml file: https://github.com/robotology/robotology-superbuild/blob/master/releases/2020.11.yaml#L109 . At the moment, the v1.0.0 has been used for all the releases of the robotology-superbuild until now. |
While testing the Windows installer for robotology-superbuild software, I executed the
yarpdev --list
command and I noticed that wearables and human-dynamics installed device are not found correctly, while all the other YARP devices are correctly installed:Click to see the outpiut of
yarpdev --list
I did not investigated in detail why this is happening, but I noticed that in this repo manually wrote
.ini
files for all the devices are still installed, while YARP has gained support to automatically generated them (reduce the possibility of errors) in version 3.2.0 : https://github.com/robotology/yarp/blob/2522239984ef3e6c26939fe740001ec08189a8cb/doc/release/v3_2_0.md#build-system .For this reason, I suggest to first of all remove the manually written
.ini
files, and use instead the much more convenient and less error prone automatic generation provided by YARP, see robotology/icub-main#586 for an example pull request.While we touch the CMake, I suggest also to call the library name of your devices in a less ambiguous way. For example, the
icub_wearable_device
YARP device installs a library calledICub
in<prefix>/lib/yarp/ICub.<ext>
, and as you imagine such a generic name is confusing for users and prone to collision with other libraries name, so called also the library<prefix>/lib/yarp/ICubWearable.<ext>
or something similar would be nice.The text was updated successfully, but these errors were encountered: